563165 – Externalize flushOperations method from DAnalysisSessionImpl

Bug 563165 - Externalize flushOperations method from DAnalysisSessionImpl

Summary: Externalize flushOperations method from DAnalysisSessionImpl

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Core (show other bugs)
Version:	6.3.0
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	6.4.0
Assignee:	Laurent Redor
QA Contact:

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2020-05-14 06:47 EDT by Laurent Redor
Modified:	2020-12-04 04:23 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Redor

2020-05-14 06:47:17 EDT

The private method "org.eclipse.sirius.business.internal.session.danalysis.DAnalysisSessionImpl.flushOperations(TransactionalEditingDomain)" can be useful in other contexts to completely clean the history.

The goal of this issue is to externalize the method in a util class. And to use it where it's possible (sometimes instead of a simple CommandStack.flush that does not flush totally).

Comment 1 Laurent Redor

2020-05-14 12:45:54 EDT

https://git.eclipse.org/r/#/c/163023/ : Proposition of fix

Comment 2 Eclipse Genie

2020-07-23 12:23:25 EDT

Gerrit change https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/163023 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5b8cadbc8668bedb3a2d456a6a03a3285aad6c7f

Comment 3 Julien Dupont

2020-10-08 10:52:10 EDT

How to verify this issue?

Comment 4 Laurent Redor

2020-11-06 05:13:47 EST

Indirectly validated through memory leak scenario in T4C.

Comment 5 Pierre-Charles David

2020-12-04 04:23:21 EST

Available in Sirius 6.4.0, see https://download.eclipse.org/sirius/updates/releases/6.4.0/ for details.