Description Laurent Redor 2020-05-14 03:42:11 EDT

In DAnalysisSessionImpl.close(IProgressMonitor), the first thing is to check if it is opened and to return without doing nothing if not.

The close method cleans "stuff" done at opening but also "stuff" done at instantiation. So if someone creates a DASI without open it, he can not "clean" this DASI and this leads to memory leaks.

The goal of this issue is to allow the close method to clean all "instantiation stuff" even if the DASI is not opened. This is the less impacting solution. Another approach would be to have a dispose method, but the order of each statement in close method is probably important.

Examples of "stuff" not cleaned:
* disable and remove ECrossReferenceAdapters
* several listeners on TransactionalEditingDomain (dRepresentationChangeListener, changeIdUpdaterListener, ...)
* flush of the CommandStack
* unload of resources
* ...