Community
Participate
Working Groups
We'll use this bug to track the release We require IP Team approval of the IP Log. We require PMC approval of the release and review materials. There's help regarding releases in the handbook. https://www.eclipse.org/projects/handbook/#release
Do I correctly assume that the 1.0 number on the release indicates that you'd like to combine this release review with a graduation review (i.e. move the project from the incubating to the mature phase)? AFAICT, there is no automated build (i.e. I don't see a pom.xml file in any of the branches that I've looked at). While not a strict requirement, build maturity (demonstrated by having a repeatable automated build) is one of the factors considered when a project engages in a graduation review to transition from incubating into mature phase. AFAICT, the project is missing legal documentation. Some plug-in do have about.html files, but not all [1]. We do expect to find a CONTRIBUTING (and/or README), NOTICES, and LICENSE file in the root of the project repository [2]. AFAICT, the project is EPL-1.0. We need the project to update to the EPL-2.0 (there's some help in Bug 530393). [1] https://www.eclipse.org/projects/handbook/#legaldoc-plugins [2] https://www.eclipse.org/projects/handbook/#legaldoc
The Bundle-Vendor on all bundles should be "Eclipse Chess Project" (it lists other companies in some cases).
(In reply to Wayne Beaton from comment #1) > Do I correctly assume that the 1.0 number on the release indicates that > you'd like to combine this release review with a graduation review (i.e. > move the project from the incubating to the mature phase)? Yes. > > AFAICT, there is no automated build (i.e. I don't see a pom.xml file in any > of the branches that I've looked at). While not a strict requirement, build > maturity (demonstrated by having a repeatable automated build) is one of the > factors considered when a project engages in a graduation review to > transition from incubating into mature phase. At the current stage, all the plugins have pom.xml for the automated build. > > AFAICT, the project is missing legal documentation. Some plug-in do have > about.html files, but not all [1]. We do expect to find a CONTRIBUTING > (and/or README), NOTICES, and LICENSE file in the root of the project > repository [2]. All plugin have the about.html file. I'm going to add the missing files to the root of the project. > > AFAICT, the project is EPL-1.0. We need the project to update to the EPL-2.0 > (there's some help in Bug 530393). We updated the license of the project. > > [1] https://www.eclipse.org/projects/handbook/#legaldoc-plugins > [2] https://www.eclipse.org/projects/handbook/#legaldoc
(In reply to Wayne Beaton from comment #2) > The Bundle-Vendor on all bundles should be "Eclipse Chess Project" (it lists > other companies in some cases). All bundles now have "Eclipse Chess Project".
I've marked the review as being a combined release and graduation review. > At the current stage, all the plugins have pom.xml for the automated build. Since invoking the build is not obvious, please add instructions to the CONTRIBUTING file. Also... the instructions that you gave me on the CQ suggest that you're building against Eclipse Neon which is very old. Does the project have a plan to move to a more recent build? I've updated our records to reflect the upgrade to EPL-2.0. Thanks.
I'm getting a failure on your build. I'm executing: [wayne@localhost org.polarsys.chess.parent]$ mvn -P "Eclipse-Neon-Java8" install -DskipTests The build gets about halfway through and breaks with this message. [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.4.0:java (mwe2Launcher) on project org.polarsys.chess.xtext.fladsl: Execution mwe2Launcher of goal org.codehaus.mojo:exec-maven-plugin:1.4.0:java failed: Plugin org.codehaus.mojo:exec-maven-plugin:1.4.0 or one of its dependencies could not be resolved: Failed to collect dependencies at org.codehaus.mojo:exec-maven-plugin:jar:1.4.0 -> org.eclipse.xtext:org.eclipse.xtext.xtext.generator:jar:2.12.0 -> org.eclipse.emf:org.eclipse.emf.codegen:jar:2.14.0 -> org.eclipse.jdt:org.eclipse.jdt.launching:jar:3.8.101 -> org.eclipse.jdt:org.eclipse.jdt.debug:jar:3.14.0 -> org.eclipse.jdt:org.eclipse.jdt.core:jar:[3.20.0,4.0.0): No versions available for org.eclipse.jdt:org.eclipse.jdt.core:jar:[3.20.0,4.0.0) within specified range -> [Help 1] Any ideas?
(In reply to Wayne Beaton from comment #6) > I'm getting a failure on your build. > > I'm executing: > > [wayne@localhost org.polarsys.chess.parent]$ mvn -P "Eclipse-Neon-Java8" > install -DskipTests > > The build gets about halfway through and breaks with this message. > > [ERROR] Failed to execute goal > org.codehaus.mojo:exec-maven-plugin:1.4.0:java (mwe2Launcher) on project > org.polarsys.chess.xtext.fladsl: Execution mwe2Launcher of goal > org.codehaus.mojo:exec-maven-plugin:1.4.0:java failed: Plugin > org.codehaus.mojo:exec-maven-plugin:1.4.0 or one of its dependencies could > not be resolved: Failed to collect dependencies at > org.codehaus.mojo:exec-maven-plugin:jar:1.4.0 -> > org.eclipse.xtext:org.eclipse.xtext.xtext.generator:jar:2.12.0 -> > org.eclipse.emf:org.eclipse.emf.codegen:jar:2.14.0 -> > org.eclipse.jdt:org.eclipse.jdt.launching:jar:3.8.101 -> > org.eclipse.jdt:org.eclipse.jdt.debug:jar:3.14.0 -> > org.eclipse.jdt:org.eclipse.jdt.core:jar:[3.20.0,4.0.0): No versions > available for org.eclipse.jdt:org.eclipse.jdt.core:jar:[3.20.0,4.0.0) within > specified range -> [Help 1] > > Any ideas? What is the setup of the environment you are using? - OS - java version - maven version
(In reply to Wayne Beaton from comment #5) > I've marked the review as being a combined release and graduation review. > > > At the current stage, all the plugins have pom.xml for the automated build. > > Since invoking the build is not obvious, please add instructions to the > CONTRIBUTING file. I'm preparing the CONTRIBUTING file. > > Also... the instructions that you gave me on the CQ suggest that you're > building against Eclipse Neon which is very old. Does the project have a > plan to move to a more recent build? Yes. This is an activity we plan to do, but it is not yet scheduled. > > I've updated our records to reflect the upgrade to EPL-2.0. Thanks.
(In reply to Alberto Debiasi from comment #7) > (In reply to Wayne Beaton from comment #6) > > I'm getting a failure on your build. > > > > I'm executing: > > > > [wayne@localhost org.polarsys.chess.parent]$ mvn -P "Eclipse-Neon-Java8" > > install -DskipTests > > > > The build gets about halfway through and breaks with this message. > > > > [ERROR] Failed to execute goal > > org.codehaus.mojo:exec-maven-plugin:1.4.0:java (mwe2Launcher) on project > > org.polarsys.chess.xtext.fladsl: Execution mwe2Launcher of goal > > org.codehaus.mojo:exec-maven-plugin:1.4.0:java failed: Plugin > > org.codehaus.mojo:exec-maven-plugin:1.4.0 or one of its dependencies could > > not be resolved: Failed to collect dependencies at > > org.codehaus.mojo:exec-maven-plugin:jar:1.4.0 -> > > org.eclipse.xtext:org.eclipse.xtext.xtext.generator:jar:2.12.0 -> > > org.eclipse.emf:org.eclipse.emf.codegen:jar:2.14.0 -> > > org.eclipse.jdt:org.eclipse.jdt.launching:jar:3.8.101 -> > > org.eclipse.jdt:org.eclipse.jdt.debug:jar:3.14.0 -> > > org.eclipse.jdt:org.eclipse.jdt.core:jar:[3.20.0,4.0.0): No versions > > available for org.eclipse.jdt:org.eclipse.jdt.core:jar:[3.20.0,4.0.0) within > > specified range -> [Help 1] > > > > Any ideas? > > What is the setup of the environment you are using? > > - OS > - java version > - maven version I prepared 2 jobs in Jenkins, and the build works (https://ci.eclipse.org/chess/). - The job 'CHESS-devel' executes 'mvn -P "Eclipse-Neon-Java8"' from the branch devel. - The job 'CHESS-master-bundle' is executing 'mvn -P "Eclipse-Neon-Java8,bundle"' from the master. The part related to the build is passed, now it is creating the bundle.
I cleared the cache and the build worked.
The IP Log is approved.
(In reply to Wayne Beaton from comment #11) > The IP Log is approved. Great! Are there other actions to take, to finalize the CHESS release?
(In reply to Alberto Debiasi from comment #12) > (In reply to Wayne Beaton from comment #11) > > The IP Log is approved. > > Great! > > Are there other actions to take, to finalize the CHESS release? Also, there is this issue open: https://bugs.eclipse.org/bugs/show_bug.cgi?id=564089
(In reply to Alberto Debiasi from comment #12) > (In reply to Wayne Beaton from comment #11) > > The IP Log is approved. > > Great! > > Are there other actions to take, to finalize the CHESS release? We require PMC approval of the release and review materials. AFAICT you still haven't sent any request on the mailing list. After we get their approval we can schedule the relase. regards, Maria Teresa
(In reply to Maria Teresa Delgado from comment #14) > (In reply to Alberto Debiasi from comment #12) > > (In reply to Wayne Beaton from comment #11) > > > The IP Log is approved. > > > > Great! > > > > Are there other actions to take, to finalize the CHESS release? > > We require PMC approval of the release and review materials. AFAICT you > still haven't sent any request on the mailing list. After we get their > approval we can schedule the relase. > regards, > Maria Teresa Thanks Maria for the response. Do I have to send a request to a specific mailing list? Could you please elaborate a bit more which action is required?
> We require PMC approval of the release and review materials. Please send a note to the polarsys-pmc list with a request to review and approve the release materials. Please be sure to tell the PMC that you intend to graduate along withy this release. There's help here: https://www.eclipse.org/projects/handbook/#release-review
Thank you for the support. Just for understanding better the process, how is this request related to the following review page? https://projects.eclipse.org/projects/polarsys.chess/reviews/1.0.0-release-review Given that Puri already opened such review, I thought that the PMC review was already ongoing.
PMC approval: https://www.eclipse.org/lists/polarsys-pmc/msg00386.html
I declare this review successful! Please continue with your release.
