Bug 563016 - Rename terminal packages to reflect real API
Summary: Rename terminal packages to reflect real API
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: terminal (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-10 12:47 EDT by Jonah Graham CLA
Modified: 2020-05-10 12:55 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonah Graham CLA 2020-05-10 12:47:06 EDT 
The terminal has packages with internal in the name which are not actually internal API.

e.g. org.eclipse.tm.internal.terminal.control is not marked as internal. Should it be, or should we rename the package now that we are in the CDT major version release phase?
Comment 1 Jonah Graham CLA 2020-05-10 12:55:20 EDT 
The commit that removed the internal was dea02eb9f9[1] which predated the creation of the separate control bundle in cbb6fb4ef1[2]

[1] https://git.eclipse.org/c/cdt/org.eclipse.cdt.git/diff/plugins/org.eclipse.tm.terminal/META-INF/MANIFEST.MF?id=dea02eb9f98dbdbcea414adf68894e8af04f23f1

[2] https://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=cbb6fb4ef12095b0dacd0d63d11268f1113805ee