Bug 562057 - [14] regression in diagnose parsing is made the test expectation
Summary: [14] regression in diagnose parsing is made the test expectation
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.16   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.16 M3   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 562103
  Show dependency tree
 
Reported: 2020-04-13 07:21 EDT by Stephan Herrmann CLA
Modified: 2020-05-19 21:08 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2020-04-13 07:21:58 EDT 
Bug 560893 made a change in org.eclipse.jdt.core.tests.compiler.parser.ComplianceDiagnoseTest.test0052() which is plain wrong: at 1.5 we are no expecting an error message suggesting to use the keyword 'record', but of course at 1.5 there is no such keyword.

As per bug 562044 comment 2 this is caused by a bogus parser21.rsc, probably created by a buggy version of jikespg.
Comment 1 Stephan Herrmann CLA 2020-04-13 07:43:13 EDT 
Filling in the link while genie doesn't talk to us: https://git.eclipse.org/r/#/c/160829/

This reverts basically all test changes made in Bug 560893.
Comment 2 Eclipse Genie CLA 2020-04-13 08:10:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/160829
Comment 3 Stephan Herrmann CLA 2020-04-13 08:25:08 EDT 
Of course at compliance 14 the previous test results are given, so I updated the affected tests to adjust their expectations to the compliance level.

@Manoj, I believe most of the diffs between patchsets #2 and #3 should ideally be reverted. It seems that diagnose parsing is less successful at 14. Do you want to take over this current bug to investigate, or should we create a new one for that?
Comment 4 Manoj N Palat CLA 2020-04-13 09:26:28 EDT 
(In reply to Stephan Herrmann from comment #3)
> Of course at compliance 14 the previous test results are given, so I updated
> the affected tests to adjust their expectations to the compliance level.
> 
> @Manoj, I believe most of the diffs between patchsets #2 and #3 should
> ideally be reverted. 
Yes, agree on that.

> It seems that diagnose parsing is less successful at
> 14. Do you want to take over this current bug to investigate, or should we
> create a new one for that?

We can commit the patch you have created and start the investigation on this bug itself - if required, later if there are substantial changes in DiagnoseParser we can create a new bug.
Comment 6 Manoj N Palat CLA 2020-04-16 01:23:18 EDT 
@Stephan: There's  another bug 552769 to address a few test failures related to the DiagnoseParser issue with record - will look investigate the DiagParser via that - restoring the assignee back to  you and resolving this.
Comment 7 Eclipse Genie CLA 2020-04-16 07:41:26 EDT 
New Gerrit change created: https://git.eclipse.org/r/161052
Comment 8 Manoj N Palat CLA 2020-04-21 02:22:29 EDT 
(In reply to Eclipse Genie from comment #7)
> New Gerrit change created: https://git.eclipse.org/r/161052

reopening for backport
Comment 10 Manoj N Palat CLA 2020-05-19 21:08:59 EDT 
Verified for Eclipse Version: 2020-06 4.16 M3 with Build id: I20200519-1800