Bug 560962 - Icons from StyleCustomizations are not taken into account for cs.Part
Summary: Icons from StyleCustomizations are not taken into account for cs.Part
Status: VERIFIED FIXED
Alias: None
Product: Capella
Classification: Polarsys
Component: Diagram (show other bugs)
Version: 1.4.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 1.4.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-10 05:51 EDT by Axel RICHARD CLA
Modified: 2020-07-21 10:55 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Axel RICHARD CLA 2020-03-10 05:51:11 EDT 
Hello,

With Capella 1.4.0, org.polarsys.capella.core.sirius.analysis.extension.style.PartComponentStyleConfiguration has been introduced through the org.eclipse.sirius.diagram.ui.styleconfigurationProvider.

In this class, the getLabelIcon method doesn't handle possible custom icons from StyleCustomizations.
It is handled in the super class org.eclipse.sirius.diagram.ui.tools.api.graphical.edit.styles.SimpleStyleConfiguration (methods useLabelIcon and useCustomIcon), so it should also be handled in PartComponentStyleConfiguration#getLabelIcon.

Best regards,
Comment 1 Florian Barbin CLA 2020-03-10 06:35:54 EDT 
DRAFT on Capella (https://github.com/eclipse/capella/commit/852d51ad79bffd32509a1e58248ef2ae657a3928) depending on a Sirius commit to make org.eclipse.sirius.diagram.ui.tools.api.graphical.edit.styles.SimpleStyleConfiguration.useCustomIcon(DDiagramElement, IGraphicalEditPart) protected.
Comment 2 Florian Barbin CLA 2020-03-10 06:43:46 EDT 
Draft for review (replace the previous link): https://github.com/eclipse/capella/commit/89ab2f405724dd9542d3dad290453aafa480327f
Comment 3 Florian Barbin CLA 2020-03-10 06:57:35 EDT 
Depends on this gerrit: https://git.eclipse.org/r/#/c/159102/
Comment 4 Philippe Dul CLA 2020-07-21 10:51:04 EDT 
Status: resolved
Resolution: fixed
Comment 5 Philippe Dul CLA 2020-07-21 10:55:12 EDT 
Status: verified
Resolution: fixed