560498 – [ELK] Consider shadow on container of type List

Bug 560498 - [ELK] Consider shadow on container of type List

Summary: [ELK] Consider shadow on container of type List

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	unspecified
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	6.3.1
Assignee:	Laurent Redor
QA Contact:	Julien Dupont

URL:
Whiteboard:
Keywords:	triaged

Depends on:
Blocks:

Reported:	2020-02-25 04:31 EST by Laurent Redor
Modified:	2020-06-19 10:22 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Gerrit Change 553251 Git Commit Git Commit

Attachments
TestElkLayout.zip (11.22 KB, application/x-zip-compressed) 2020-02-25 04:31 EST, Laurent Redor	no flags	Details
ELK_containerListProblems.png (29.90 KB, image/png) 2020-02-25 04:32 EST, Laurent Redor	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Redor

2020-02-25 04:31:32 EST

Created attachment 281921 [details]
TestElkLayout.zip

The shadow is considered for standard container (see ElkDiagramLayoutConnector.createNode()) but it was not for the List.
The result is:
* Wrong size: labels are truncated (this is not the case in "pure" ELK)
* Wrong anchor for edges: Slight bendpoint can appears (this is not the case in "pure" ELK)

Steps to reproduce:
* Import project TestElkLayout from TestElkLayout.zip
* Open diagram "diagramWithList"
* Launch an "Arrange All"
* Expected: 
    * The diagram is layouted, 
    * the list item "listItemWithALongName" of "MyClass2" is displayed without wrapping
    * the edge from "MyClass1" to "MyClass2" has only 2 points, start and end, without intermediate points.
    * The screenshot "ELK_containerListProblems.png" shows the 2 current problems.

Comment 1 Laurent Redor

2020-02-25 04:32:21 EST

Created attachment 281922 [details]
ELK_containerListProblems.png

Comment 2 Eclipse Genie

2020-02-27 13:17:58 EST

New Gerrit change created: https://git.eclipse.org/r/158533

Comment 3 Eclipse Genie

2020-02-27 13:18:00 EST

New Gerrit change created: https://git.eclipse.org/r/158534

Comment 4 Eclipse Genie

2020-03-15 15:55:46 EDT

Gerrit change https://git.eclipse.org/r/158533 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=aa09950cb833a721ee0564a6413b8feee21daecc

Comment 5 Eclipse Genie

2020-03-15 15:55:47 EDT

Gerrit change https://git.eclipse.org/r/158534 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d70a4a2def459ad317c94162166039023cae9aeb

Comment 6 Laurent Redor

2020-03-15 16:03:42 EDT

Steps to validate:
* See Steps to reproduce in description (comment 0)

Comment 7 Pierre-Charles David

2020-06-19 10:22:17 EDT

Available in Sirius 6.3.1 (part of Eclipse 2020-06). See https://wiki.eclipse.org/Sirius/6.3.1 for details on the release.