Bug 559029 - In the MVC Logo example, CloneOnClickHandler selection is overwritten by FocusAndSelectOnClickHandler
Summary: In the MVC Logo example, CloneOnClickHandler selection is overwritten by Focu...
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF MVC (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard: low-hanging fruit
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-10 10:09 EST by Matthias Wienand CLA
Modified: 2020-01-10 10:10 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Wienand CLA 2020-01-10 10:09:46 EST 
The CloneOnClickHandler should clone the clicked part and select the clone. However, when FocusAndSelectOnClickHandler is executed afterwards on the clicked part, the selection is changed again, overwriting the desired behavior.

Possible solutions:

1) Overwrite the default FocusAndSelectOnClickHandler, so that it will not be active when cloning is done.

2) Overwrite the DefaultHandlerResolver so that only the first IOnClickHandler is executed.

3) Convert the CloneOnClickHandler into a CloneOnDragHandler (implementing IOnDragHandler) so that it is executed after the click handlers.