Community
Participate
Working Groups
Method VersionRange.getMaximum() is deprecated. The method's documentation advertises to use VersionRange.getRight() instead.
New Gerrit change created: https://git.eclipse.org/r/154363
Gerrit change https://git.eclipse.org/r/154363 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=345c700637dea3a8f7b1029f2fdb393e842802e3
There are 15 pde build test failures. Is it because of this change?
Reopened to investigate if this is the cause. Karsten, if you think this is not the cause, you can resolve this bug again.
(In reply to Vikas Chandra from comment #3) > There are 15 pde build test failures. Is it because of this change? Yes, it is. getRight() is semantically different to getMaximum(), later can return null, and we must adopt code to deal with this, see javadoc of getMaximum() why. Code in question is: at org.eclipse.pde.internal.build.site.ReachablePlugin.substract(ReachablePlugin.java:79) at org.eclipse.pde.internal.build.site.ReachablePlugin.compareTo(ReachablePlugin.java:58) The commit 345c700637dea3a8f7b1029f2fdb393e842802e3 must be partly reverted, I will push the patch, because I can't see 15 test fails on all platforms, it must be zero (at least for Linux :-)). Stack for the record: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/build.xml:94: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/templates/headless-build/customTargets.xml:13: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/productBuild/allElements.xml:23: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/genericTargets.xml:112: java.lang.NullPointerException /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/productBuild/productBuild.xml:45: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/build.xml:94: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/templates/headless-build/customTargets.xml:13: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/productBuild/allElements.xml:23: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/genericTargets.xml:112: java.lang.NullPointerException at org.apache.tools.ant.ProjectHelper.addLocationToBuildException(ProjectHelper.java:571) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:440) at org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor609.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) at org.apache.tools.ant.Task.perform(Task.java:350) at org.apache.tools.ant.Target.execute(Target.java:449) at org.apache.tools.ant.Target.performTasks(Target.java:470) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391) at org.apache.tools.ant.Project.executeTarget(Project.java:1364) at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41) at org.eclipse.ant.internal.core.ant.EclipseDefaultExecutor.executeTargets(EclipseDefaultExecutor.java:39) at org.apache.tools.ant.Project.executeTargets(Project.java:1254) at org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:712) at org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:573) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.eclipse.ant.core.AntRunner.run(AntRunner.java:514) at org.eclipse.pde.build.tests.PDETestCase.runAntScript(PDETestCase.java:155) at org.eclipse.pde.build.tests.PDETestCase.runAntScript(PDETestCase.java:147) at org.eclipse.pde.build.tests.PDETestCase.runProductBuild(PDETestCase.java:133) at org.eclipse.pde.build.internal.tests.p2.PublishingTests.testPublish_FeatureBasedProduct(PublishingTests.java:1587) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:40) at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) at java.util.Iterator.forEachRemaining(Iterator.java:116) at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481) at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471) at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418) at org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80) at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:71) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:229) at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:197) at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:211) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:191) at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128) at org.eclipse.test.EclipseTestRunner.runTests(EclipseTestRunner.java:226) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:202) at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:53) at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:36) at org.eclipse.test.CoreTestApplication.start(CoreTestApplication.java:44) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:657) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:594) at org.eclipse.equinox.launcher.Main.run(Main.java:1465) at org.eclipse.equinox.launcher.Main.main(Main.java:1438) at org.eclipse.core.launcher.Main.main(Main.java:44) Caused by: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/build.xml:94: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/templates/headless-build/customTargets.xml:13: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/productBuild/allElements.xml:23: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/genericTargets.xml:112: java.lang.NullPointerException at org.apache.tools.ant.ProjectHelper.addLocationToBuildException(ProjectHelper.java:571) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:440) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor609.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) at org.apache.tools.ant.Task.perform(Task.java:350) at org.apache.tools.ant.Target.execute(Target.java:449) at org.apache.tools.ant.Target.performTasks(Target.java:470) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) at org.eclipse.ant.internal.core.ant.EclipseSingleCheckExecutor.executeTargets(EclipseSingleCheckExecutor.java:37) at org.apache.tools.ant.Project.executeTargets(Project.java:1254) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) ... 90 more Caused by: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/templates/headless-build/customTargets.xml:13: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/productBuild/allElements.xml:23: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/genericTargets.xml:112: java.lang.NullPointerException at org.apache.tools.ant.ProjectHelper.addLocationToBuildException(ProjectHelper.java:571) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:440) at org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:106) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor609.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) at org.apache.tools.ant.Task.perform(Task.java:350) at org.apache.tools.ant.Target.execute(Target.java:449) at org.apache.tools.ant.Target.performTasks(Target.java:470) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) at org.eclipse.ant.internal.core.ant.EclipseSingleCheckExecutor.executeTargets(EclipseSingleCheckExecutor.java:37) at org.apache.tools.ant.Project.executeTargets(Project.java:1254) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) ... 103 more Caused by: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/productBuild/allElements.xml:23: The following error occurred while executing this line: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/genericTargets.xml:112: java.lang.NullPointerException at org.apache.tools.ant.ProjectHelper.addLocationToBuildException(ProjectHelper.java:571) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:440) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor609.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) at org.apache.tools.ant.Task.perform(Task.java:350) at org.apache.tools.ant.Target.execute(Target.java:449) at org.apache.tools.ant.Target.performTasks(Target.java:470) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) at org.eclipse.ant.internal.core.ant.EclipseSingleCheckExecutor.executeTargets(EclipseSingleCheckExecutor.java:37) at org.apache.tools.ant.Project.executeTargets(Project.java:1254) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) ... 117 more Caused by: /home/cbi/genie.releng/workspace/ep415I-unit-cen64-gtk3-java8/workarea/I20191212-1800/eclipse-testing/test-eclipse/eclipse/plugins/org.eclipse.pde.build_3.10.700.v20191211-2130/scripts/genericTargets.xml:112: java.lang.NullPointerException at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:109) at org.apache.tools.ant.Task.perform(Task.java:350) at org.apache.tools.ant.Target.execute(Target.java:449) at org.apache.tools.ant.Target.performTasks(Target.java:470) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1391) at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:36) at org.eclipse.ant.internal.core.ant.EclipseSingleCheckExecutor.executeTargets(EclipseSingleCheckExecutor.java:37) at org.apache.tools.ant.Project.executeTargets(Project.java:1254) at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:437) ... 130 more Caused by: java.lang.NullPointerException at org.eclipse.pde.internal.build.site.ReachablePlugin.substract(ReachablePlugin.java:79) at org.eclipse.pde.internal.build.site.ReachablePlugin.compareTo(ReachablePlugin.java:58) at java.util.TreeMap.compare(TreeMap.java:1294) at java.util.TreeMap.put(TreeMap.java:538) at java.util.TreeSet.add(TreeSet.java:255) at org.eclipse.pde.internal.build.site.BuildTimeSite.findAllReferencedPlugins(BuildTimeSite.java:410) at org.eclipse.pde.internal.build.site.BuildTimeSite.getRegistry(BuildTimeSite.java:124) at org.eclipse.pde.internal.build.builder.BuildDirector.generateChildrenScripts(BuildDirector.java:297) at org.eclipse.pde.internal.build.builder.BuildDirector.generate(BuildDirector.java:231) at org.eclipse.pde.internal.build.builder.BuildDirector.generateIncludedFeatureBuildFile(BuildDirector.java:269) at org.eclipse.pde.internal.build.builder.BuildDirector.generate(BuildDirector.java:229) at org.eclipse.pde.internal.build.builder.BuildDirector.generate(BuildDirector.java:224) at org.eclipse.pde.internal.build.BuildScriptGenerator.generateFeatures(BuildScriptGenerator.java:253) at org.eclipse.pde.internal.build.BuildScriptGenerator.generate(BuildScriptGenerator.java:130) at org.eclipse.pde.internal.build.tasks.BuildScriptGeneratorTask.run(BuildScriptGeneratorTask.java:110) at org.eclipse.pde.internal.build.tasks.BuildScriptGeneratorTask.execute(BuildScriptGeneratorTask.java:96) at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292) at sun.reflect.GeneratedMethodAccessor609.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99) ... 138 more
(In reply to Andrey Loskutov from comment #5) > getRight() is semantically different to getMaximum(), later can return null, correction: getRight() can return null.
New Gerrit change created: https://git.eclipse.org/r/154493
Gerrit change https://git.eclipse.org/r/154493 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=fd4a96a9d063ba324a809e77ccca9dd894ae2d81
I'll come up with an improved patch. Thanks for noticing!
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.