Community
Participate
Working Groups
Hi, I do like the new splash screen with "IDE", but it seems that it's not consistently applied. For example: Eclipse IDE for Java Developers on Windows: - splash screen with "IDE" if downloaded as a package(zip) - splash screen without "IDE" if using the installer Eclipse IDE for Java Developers on macOS: - splash screen without "IDE" if downloaded as a package(zip) - splash screen without "IDE" if using the installer I didn't check on Linux or any other package(Eclipse IDE for Enterprise Java Developers, for example)
In eclipse platform project we use splash with no IDE(this is defined in . In packaged products its with IDE. Splash screen is defined in org.eclipse.epp.package.common for packaged products and org.eclipse.platform for platform products. Need to investigate which splash screen is picked up while creating a product using eclipse installer. Assigning to Oomph for further investigations
It sounds like there is also an issue for Mac, but at least that's consistent... Eike and I have looked closely at how all this works. Some things are happening in the native code while other things are happening in the Main launcher. It's all kind of confusing... It's also strange that the config.ini looks like this for all products: eclipse.product=org.eclipse.platform.ide osgi.splashPath=platform\:/base/plugins/org.eclipse.platform But those values, I believe are effectively overridden by what's in the eclipse.ini: -product org.eclipse.epp.package.java.product -showsplash org.eclipse.epp.package.common The installer does produce the correct values for these, but the native launcher looks for org.eclipse.epp.package.common in the plugins folder (from what I can tell looking at the *.c code). But for a shared bundle pool installation, that bundle is not in the plugins folder of the installation but rather the plugins folder of the shared bundle pool. Even if the native launcher looked in that folder, it would need to be careful to find the correct version; there could be a great many versions and the largest version is not necessarily the one being used by the current installation. Fortunately the native launcher does properly process an absolute path, so we can specify something like this: -showsplash C:\user-simrel-clean\.p2\pool\plugins\org.eclipse.epp.package.common_4.14.0.20191205-0952 We need to do the processing/adjustment of the eclipse.ini -showsplash value both when we install using the installer and also even when Eclipse does a normal update. Fortunately we already have hooks (a post commit listener) in place for doing adjustments for other reasons, so we can add additional processing for this case to that.
The fix is committed to master: https://git.eclipse.org/c/oomph/org.eclipse.oomph.git/commit/?id=9e48c809e94254189fca357c16da2e9c4764e930
Thanks, Works on Windows, but on macOS it still only use the splash screen without "IDE". It would be nice to have the same splash screen on Windows, macOS & Linux
(In reply to Ionuț Ursuleanu from comment #4) > Thanks, > > Works on Windows, but on macOS it still only use the splash screen without > "IDE". It would be nice to have the same splash screen on Windows, macOS & > Linux As described here: Eclipse IDE for Java Developers on macOS: - splash screen without "IDE" if downloaded as a package(zip) - splash screen without "IDE" if using the installer So this sounds like a problem that cannot be addressed by Oomph because it's not Oomph-specific. I'd suggest opening a new bug with the latest new details because this remaining Mac-specific problem must be addressed by the platform not by Oomph. Given that it occurs for downloaded packages as well as for installer-installed packages it would appear to be a problem with how the Mac native launcher processes the -showsplash argument.
