Bug 553820 - Add preferences for Jump links properties
Summary: Add preferences for Jump links properties
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 6.3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 6.3.1   Edit
Assignee: Project Inbox CLA
QA Contact: Jessy Mallet CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 565399
  Show dependency tree
 
Reported: 2019-12-05 09:25 EST by Laurent Redor CLA
Modified: 2020-07-21 10:59 EDT (History)
2 users (show)

See Also:


Attachments
JumpLinksTest-withCreationTool.zip (5.78 KB, application/x-zip-compressed)
2020-02-10 10:55 EST, Laurent Redor CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2019-12-05 09:25:50 EST
The goal of this feature is to allow end-user to initialize jump links properties of new edge with specific default values. These properties are: the status and the type of the jump links, and the reverse option.
Comment 2 Eclipse Genie CLA 2020-02-06 12:17:33 EST
New Gerrit change created: https://git.eclipse.org/r/157295
Comment 3 Laurent Redor CLA 2020-02-10 10:54:56 EST
Steps to validate
* Import project JumpLinksTest from "JumpLinksTest-withCreationTool.zip" (same as bug 553775 but with an edge creation tool)
* Open the preference page "Sirius/Sirius Diagram/Connections"
* You should see some preferences concerning Jump links default values (like described on documentation "Sirius/Sirius User Manual/Diagrams/Preferences/Connections" (https://www.eclipse.org/sirius/doc/user/diagrams/Diagrams.html#Connections)
* By default, "Jump links" preference is disabled, "Status" is equal to "None", "Type" is equal to "Semi-Circle", and "Reverse jump links" is disabled.
* Open "diagram1-simple"
* Expected: The edge from "C1" to "C2" is cut on the intersection with the edge from "C3" to "C4". This is the new type of jump link (bug 553775).
* Select this edge
* Open the Properties view
* Select the Appearance tab of it
* Expected: The status "All" us selected and the type "Tunnel" is selected. The "Reset style properties to default values" button is enabled.
* Click on "Reset style properties to default values" button.
* Expected: status is reset to "None", type is reset to "Semi-Circle" as they are the Sirius default values. The "Reset style properties to default values" button is disabled as all fields have the default values.
* Open the preference page "Sirius/Sirius Diagram/Connections"
* Enable "Jump links" to override the Sirius default values
* Select "All" for the "Status" preference
* Select "Square" for the "Type" preference
* Unable the "Reverse jump links" preference
* Apply and Close
* Select the diagram and select again the edge from C1 to C2 (to force a refresh of the Properties view)
* Expected: The "Reset style properties to default values" button is enabled (as the default values have been changed through the preferences).
* Click on "Reset style properties to default values" button.
* Expected: status is reset to "All", type is reset to "Square" and "Reverse jump links" is enabled as they are the "new" default values defined in the preferences. The "Reset style properties to default values" button is disabled as all fields have the default values.
* Open the preference page "Sirius/Sirius Diagram/Connections"
* Click on "Restore Defaults" button.
* Expected: "Jump links" preference is disabled, "Status" is equal to "None", "Type" is equal to "Semi-Circle", and "Reverse jump links" is disabled.
* Enable "Jump links" to override the Sirius default values
* Select "All" for the "Status" preference
* Select "Square" for the "Type" preference
* Disable "Jump links"
* Apply and Close
* Customize preferences via -pluginCustomization
** In the file plugin_customization.ini, at the root of eclipse installation, add the lines
   org.eclipse.sirius.diagram/Sirius.Connectors.JumpLink.enableOverride=true
   org.eclipse.sirius.diagram/Sirius.Connectors.JumpLink.status=3
   org.eclipse.sirius.diagram/Sirius.Connectors.JumpLink.type=3
** For a launch configuration, the plugin_customization.ini to use needs to be added in the "Program argument" section by adding "-pluginCustomization plugin_customization.ini".
** Otherwise, directly set this path in the eclipse.ini 
* Save the diagram
* Restart Eclipse
* Open the preference page "Sirius/Sirius Diagram/Connections"
* Expected: preferences should be as previously set : status is equal to "All", type is equal to "Square", "Reverse jump links" is disabled and "Jump links" is disabled.
* Click on "Restore Defaults" button.
* Expected: "Jump links" preference is enabled, "Status" is equal to "Above" (value 3 of enum JumpLinkStatus), "Type" is equal to "Tunnel" (value 3 of enum JumpLinkType), and "Reverse jump links" is disabled.
* Apply and Close
* Select the diagram and select again the edge from C1 to C2 (to force a refresh of the Properties view)
* Select the Appearance tab of it
* Click on "Reset style properties to default values" button.
* Expected: status is reset to "Above", type is reset to "Tunnel" and "Reverse jump links" is disabled as they are the "new" default values defined in the preferences throught the plugin_customization.ini. The "Reset style properties to default values" button is disabled as all fields have the default values.
* Use the "Reference" creation tool to create an edge between "C2" and "C4"
* Expected: In the "Appearance" tab of the "Preperties" view, status is equal to "Above", type is equal to "Tunnel" and "Reverse jump links" is disabled as they are defined in the preferences.
Comment 4 Laurent Redor CLA 2020-02-10 10:55:30 EST
Created attachment 281766 [details]
JumpLinksTest-withCreationTool.zip
Comment 6 Jessy Mallet CLA 2020-03-31 11:38:44 EDT
Validated with Sirius 6.3.1.202003201424
Comment 7 Pierre-Charles David CLA 2020-06-19 10:22:15 EDT
Available in Sirius 6.3.1 (part of Eclipse 2020-06). See https://wiki.eclipse.org/Sirius/6.3.1 for details on the release.