Community
Participate
Working Groups
Created attachment 280740 [details] Push Similar to Bug 553223, I see Push to Gerrit (which does not make sense, as the repo I'm working on is a pure Github repo) but not Push.
Push to Gerrit is a default handler. That it's visible in Quick Access is part of bug 495064. But if I fix this, I'll also remove the default handler for Fetch from Gerrit -- there we even added a repository selection dialog due to bug 507733 which you had opened. If the default handler is removed, "Fetch from Gerrit" and "Push to Gerrit" will be available only if the selection defines a Gerrit-enabled repository, so then we can even roll back https://git.eclipse.org/r/#/c/128357/. Why "Push" is not showing up is unclear; possibly some strange behavior in the staging view. (No staged or unstaged changes, focus probably in the commit message editor.)
The behavior of https://git.eclipse.org/r/#/c/128357/ is still really nice, e.g. if I "just work" in Eclipse for example using an example RCP app and think the change I'm testing is ready to be used, I can Ctrl+3 -> Push to Gerrit and select the repo I want to work with.
Well, you can't have both: either both are always active default handlers and thus show up in Ctrl-3 always and then Push to Gerrit should also get such a dialog, or both are active only if the selection defines a Gerrit context and then they will not show up when not appropriate, and the the dialog in Fetch from Gerrit is removed.
(In reply to Thomas Wolf from comment #3) > Well, you can't have both: either both are always active default handlers > and thus show up in Ctrl-3 always and then Push to Gerrit should also get > such a dialog, or both are active only if the selection defines a Gerrit > context and then they will not show up when not appropriate, and the the > dialog in Fetch from Gerrit is removed. Maybe we should should have only one push command. And then depending on the Git repository it either pushes to Gerrit or to the Git repo. Command line also only has one push command.
(In reply to Lars Vogel from comment #4) > Maybe we should should have only one push command. And then depending on the > Git repository it either pushes to Gerrit or to the Git repo. Command line > also only has one push command. -1 for that. Some people want to push directly bypassing Gerrit. I'd rather favor making these Gerrit handlers active only in a Gerrit context and removing the repo selection dialog. Plus, of course checking and possibly fixing that problem with the staging view.
(In reply to Thomas Wolf from comment #5) > (In reply to Lars Vogel from comment #4) > > Maybe we should should have only one push command. And then depending on the > > Git repository it either pushes to Gerrit or to the Git repo. Command line > > also only has one push command. > > -1 for that. Some people want to push directly bypassing Gerrit. > > I'd rather favor making these Gerrit handlers active only in a Gerrit > context and removing the repo selection dialog. Plus, of course checking and > possibly fixing that problem with the staging view. Of if nothing is selected, trigger a repo selection dialog and trigger the correct command (Gerrit push or normal push) afterwards.
(In reply to Lars Vogel from comment #6) > Of if nothing is selected, trigger a repo selection dialog... Which means some always active handler, which may show up when not appropriate in Ctrl-3. A unified "Push" is not possible, There _are_ huge difference between "Push...", "Push to upstream", "Push to Gerrit", and so on. "Push..." and "Push to upstream" could benefit from such a repo selection dialog, but "Push to Gerrit" (and likewise Fetch) would better only be active in a Gerrit context.
(In reply to Thomas Wolf from comment #7) > (In reply to Lars Vogel from comment #6) > > Of if nothing is selected, trigger a repo selection dialog... > > Which means some always active handler, which may show up when not > appropriate in Ctrl-3. A unified "Push" is not possible, There _are_ huge > difference between "Push...", "Push to upstream", "Push to Gerrit", and so > on. "Push..." and "Push to upstream" could benefit from such a repo > selection dialog, but "Push to Gerrit" (and likewise Fetch) would better > only be active in a Gerrit context. +1
Push doesn't show up because there is simply no handler for it active on the view's selection, which is either some StagingEntries or, if there is no selection in the staged/unstaged viewers, a special selection containing the repository. We would have to see which command handlers would make sense to also enable for the staging view's selection, and we'd have to be careful about it. (See bug 541752 for the reason.)
