Bug 553181 - Allow customization of validation icon and color calculation
Summary: Allow customization of validation icon and color calculation
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.23.0   Edit
Assignee: Lucas Koehler CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2019-11-18 09:45 EST by Lucas Koehler CLA
Modified: 2019-11-28 04:29 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Koehler CLA 2019-11-18 09:45:59 EST 
Currently, validation icons and colors are determined by directly using the SWTValidationHelper in the AbstractControlSWTRenderer. While colors and icons itself can already be customized with ViewTemplates, it is not possible to customize the calculation itself. This is a problem if, for instance, different logic is needed than the current one which only uses the diagnostic severity together with the view templates.

Consequently, the calculation of validation icons and colors should be done by an OSGI service which can be replaced by a custom implementation if needed. The standard implementation in EMF Forms will further use the SWTValidationHelper internally.
Comment 1 Eclipse Genie CLA 2019-11-18 10:57:15 EST 
New Gerrit change created: https://git.eclipse.org/r/152878
Comment 3 Eclipse Genie CLA 2019-11-28 04:21:32 EST 
New Gerrit change created: https://git.eclipse.org/r/153522