Bug 552301 - Certificates look weirdly formatted (for example in Oomph)
Summary: Certificates look weirdly formatted (for example in Oomph)
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Security (show other bugs)
Version: 4.13   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Security Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2019-10-22 03:54 EDT by Lars Vogel CLA
Modified: 2021-10-15 05:26 EDT (History)
5 users (show)

See Also:


Attachments
Screenshot (38.26 KB, image/png)
2019-10-22 03:54 EDT, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-10-22 03:54:02 EDT
Created attachment 280370 [details]
Screenshot

The backslash in the certificate looks bad to me in the Certificates dialog, which I think comes from platform but is used by other tools like Oomph.

Is this an issue with with the certificate or should be dialog remove the backslashes?
Comment 1 Ed Merks CLA 2019-10-22 03:59:34 EDT
The underlying infrastructure for this is in Equinox and used by p2.
Comment 2 Thomas Watson CLA 2019-10-22 09:50:20 EDT
I think something is going wrong in:

org.eclipse.equinox.internal.p2.ui.viewers.CertificateLabelProvider.getText(Object)

	public String getText(Object element) {
		Certificate cert = null;
		if (element instanceof TreeNode) {
			cert = (Certificate) ((TreeNode) element).getValue();
		}
		if (cert != null) {
			X500PrincipalHelper principalHelper = new X500PrincipalHelper(((X509Certificate) cert).getSubjectX500Principal());
			return principalHelper.getCN() + "; " + principalHelper.getOU() + "; " + principalHelper.getO(); //$NON-NLS-1$ //$NON-NLS-2$
		}
		return ""; //$NON-NLS-1$
	}

Particularly in the calls to principalHelper.  The getCN().toString() must be escaping the commas of the in org.eclipse.equinox.internal.provisional.security.ui.X500PrincipalHelper
Comment 3 Eclipse Genie CLA 2021-10-15 05:26:06 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.