Bug 552243 - Security warning for unsigned content dialog should not use an error icon
Summary: Security warning for unsigned content dialog should not use an error icon
Status: RESOLVED WORKSFORME
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted, usability
Depends on:
Blocks:
 
Reported: 2019-10-19 07:32 EDT by Lars Vogel CLA
Modified: 2020-02-16 05:49 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-10-19 07:32:01 EDT 
If you install unsigned content the resulting dialog shows an error instead of a warning.

Relevant code is located in package org.eclipse.equinox.internal.p2.ui ValidationDialogServiceUI
Comment 1 Michael Keppler CLA 2019-10-20 08:40:56 EDT 
Can you please attach a screenshot of the exact dialog (with expanded details, if available)? I see that warning since years, and for me it has always been with a warning image.

Looking at the code, an error image should only appear if the IStatus given to the dialog is either null or has severity error. I currently don't see where that IStatus object would come from in the class you mentioned.
Comment 2 Ed Merks CLA 2020-02-16 05:49:15 EST 
This has always worked for me as well.  Perhaps there are only errors if the signature is invalid? In any case, without something that replicates the problem there's no fixing it.