Bug 552077 - closeProjectsMissingAfterCheckout superfluous for newly created branch from HEAD
Summary: closeProjectsMissingAfterCheckout superfluous for newly created branch from HEAD
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 5.6   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-14 06:09 EDT by Michael Keppler CLA
Modified: 2019-10-14 06:09 EDT (History)
0 users

See Also:

Attachments
profiler screenshot (43.71 KB, image/png)
2019-10-14 06:09 EDT, Michael Keppler CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Keppler CLA 2019-10-14 06:09:20 EDT 
Created attachment 280245 [details]
profiler screenshot

I just created a new branch from my locally checked out master branch and profiled that. We run "closeProjectsMissingAfterCheckout" with a big FileWalk in this case, although we can say for sure that no project will be missing, since the files are identical.

closeProjectsMissingAfterCheckout needs an additional early return for the commit before and after checkout being identical.

PS: I'm not sure if the other jgit part in the profiler screenshot is reasonable under these circumstances, or if that can eventually be optimized, too.