Bug 551247 - API check does not recognize changed class hierarchy across dependencies
Summary: API check does not recognize changed class hierarchy across dependencies
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE API Tools Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: investigate
: 551364 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-09-19 08:47 EDT by Paul Pazderski CLA
Modified: 2023-10-20 07:18 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Pazderski CLA 2019-09-19 08:47:17 EDT
I hope the title is accurate. This is kind of an follow up to bug 551109 where API tools required a minor version increment because a parent class from a dependency added a new interface.

After incrementing minor version API tools in IDE are happy but instead API check in Gerrit build fails because it does not see anything changed (it not recognize the added interface as new) and complains about unnecessary incremented minor version.

https://ci.eclipse.org/platform/job/eclipse.platform.debug-Gerrit/1232/consoleFull

12:39:24 1 API ERRORS
12:39:24 * Marker [on: /org.eclipse.ui.console/META-INF/MANIFEST.MF, id: 4, type: org.eclipse.pde.api.tools.version_numbering, attributes: [apiMarkerID: 4, charEnd: 165, charStart: 150, description: , lineNumber: 5, message: The minor version should be the same for version 3.9.0, since no new APIs have been added since version 3.8.600, messagearguments: 3.9.0#3.8.600, problemid: 926941240, severity: 2, sourceId: API Tools, version: 3.8.600.qualifier], created: 9/19/19 10:39 AM]
12:39:24 2 API warnings
12:39:24 * Marker [on: /org.eclipse.ui.console, id: 5, type: org.eclipse.pde.api.tools.api_usage, attributes: [apiMarkerID: 3, charEnd: -1, charStart: -1, lineNumber: 0, message: Execution environment references were not checked for 'org.eclipse.ui.console' because no environment descriptions are installed. , messagearguments: org.eclipse.ui.console, problemid: 665845798, severity: 1, sourceId: API Tools], created: 9/19/19 10:39 AM]
12:39:24 * Marker [on: /org.eclipse.ui.console/src/org/eclipse/ui/console/TextConsolePage.java, id: 6, type: org.eclipse.pde.api.tools.api_usage, attributes: [apiMarkerID: 3, charEnd: 3031, charStart: 3016, lineNumber: 75, message: TextConsolePage illegally implements IPage via IPageBookViewPage, messagearguments: IPageBookViewPage#TextConsolePage#IPage, org.eclipse.jdt.internal.core.JavaModelManager.handleId: =org.eclipse.ui.console/src<org.eclipse.ui.console{TextConsolePage.java[TextConsolePage, problemTypeName: org.eclipse.ui.console.TextConsolePage, problemid: 574668824, severity: 1, sourceId: API Tools], created: 9/19/19 10:39 AM]
Comment 1 Andrey Loskutov CLA 2019-09-19 09:00:22 EDT
Mickael, Vikas: could it be that we must update the baseline with which we do the API compare?
Comment 2 Paul Pazderski CLA 2019-09-23 05:47:04 EDT
*** Bug 551364 has been marked as a duplicate of this bug. ***
Comment 3 Paul Pazderski CLA 2019-09-23 05:51:13 EDT
Mickael, Vikas: do you need the current broken state to investigate the problem? If not I would merge https://git.eclipse.org/r/#/c/148661/ to fix the failing gerrit builds.
Comment 4 Mickael Istria CLA 2019-09-23 05:56:07 EDT
(In reply to Paul Pazderski from comment #3)
> Mickael, Vikas: do you need the current broken state to investigate the
> problem? If not I would merge https://git.eclipse.org/r/#/c/148661/ to fix
> the failing gerrit builds.

I don't think I'll get involved in this issue for some time as I'm busy with higher priority stuff. So don't wait for me to merge it.
I don't know for Vikas though.
Comment 5 Vikas Chandra CLA 2019-09-23 06:19:02 EDT
You can merge. In any case the change can be reversed to reproduce ( time permitting)
Comment 6 Paul Pazderski CLA 2019-09-23 06:30:18 EDT
Done. The underlying problem remains but Gerrit builds should work again.
Comment 7 Eclipse Genie CLA 2021-10-29 14:17:31 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 8 Eclipse Genie CLA 2023-10-20 07:18:17 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.