Community
Participate
Working Groups
API tooling should report unnecessary version increment for bundles, where version was already incremented. See https://git.eclipse.org/r/#/c/145561/13/org.eclipse.jface.text/META-INF/MANIFEST.MF@5 The minor version segment was bumped for bug 547683, and after that service segment increment was not needed in the change above.
New Gerrit change created: https://git.eclipse.org/r/149908
Would at be possible to get rid of manual update of the version increment completely by implementing a gerrit plugin that does this for you whenever it is necessary? There are plugins for checking commit message length and other tasks - I am not sure if the relevant base version to be compared to can be computed at all of if it is just something only the developer knows. see https://gerrit.googlesource.com/plugins/ Or is the eclipse gerrit installation something that should not be touched?
(In reply to Carsten Hammer from comment #2) > Would at be possible to get rid of manual update of the version increment > completely by implementing a gerrit plugin that does this for you whenever > it is necessary? Not really. Versioning isn't something that can safely be automated. It's better to report failure and let developer discuss remediation than trying to implement a bot that would automatically change things, at the risk of being faulty. See, it's already hard to automate good checks and this still has bugs or limitation despite being very mature; so imagine how harder and less safe it would be to automate the change here. > Or is the eclipse gerrit installation something that should not be touched? It's also another point: we don't really want to put too much logic in Gerrit. We need checks and smartness to be reproducible locally, on other Git repos, on other CIs... So smartness is better being placed in the build tool (Maven) for more portability and reusability.
Created attachment 280503 [details] Proposed changes The image is self explanatory
Andrey, can you please look at comment#4 ( or you can try out https://git.eclipse.org/r/149908)
Gerrit change https://git.eclipse.org/r/149908 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a0dcac6a1d2de86f4e5ecf02446055cb5cf55bba
This can be tried out on 6th Nov 6pm build. I will also look out for new versioning issues on the build page ( if any)
I tested on Version: 2019-12 (4.14) Build id: I20191106-1805 Seem to work as expected ! Pending item: N&N item and documentation update ! I will do those before marking this as verified
Thanks Vikas, that's a great addition!
Today my builds are verifying plugin.xml very long. Maybe related to this change?Please check Bug 552775.
(In reply to Lars Vogel from comment #10) > Today my builds are verifying plugin.xml very long. Maybe related to this > change?Please check Bug 552775. Unlikely since "verifying *" uses PDE compiler builder and in this bug only API tool changes were done and will affect *API*Builders* only. I will investigate anyway !
