Bug 550971 - DiagnosticView always expands itself
Summary: DiagnosticView always expands itself
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: EMF Forms (show other bugs)
Version: 1.22.0   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 1.23.0   Edit
Assignee: Christian Damus CLA
QA Contact: Eugen Neufeld CLA
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2019-09-11 08:09 EDT by Christian Damus CLA
Modified: 2019-10-28 07:45 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2019-09-11 08:09:44 EDT
When the DiagnosticView gets an update, it does an "expand all" on its tree.  This has two problems:

- profiling a private client application shows that as much as 25% of the time taken in changing row selection in a table control is attributed to expand-all in this view because the validation service validates every selection
- in my private client application, I have a "collapse all" button in the view's toolbar.  It's irritating to a user who uses this to collapse the diagnostic view tree that changing the selection in a table expands everything again

Either the DiagnosticView should just not expand all when it is updated with validation changes, or it should provide some API that lets clients customize this behaviour.
Comment 1 Eclipse Genie CLA 2019-09-11 08:58:37 EDT
New Gerrit change created: https://git.eclipse.org/r/149344
Comment 3 Christian Damus CLA 2019-09-11 16:37:28 EDT
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/149344 was merged to [develop].
Comment 4 Christian Damus CLA 2019-09-27 07:14:47 EDT
Fixpublished in the 1230_201909261922 build.
Comment 5 Jonas Helming CLA 2019-10-28 04:17:49 EDT
should this be marked with "test"?
Comment 6 Eugen Neufeld CLA 2019-10-28 07:45:03 EDT
## TESTING INFORMATION
### Summary of the critical part of the change

The default implementation of the DiagnosticView expanded all nodes which led to performance issues.

### Potential regressions

Regression may occur in UI applications that previously assumed or required
that the diagnostic view is expanded.