Comment 1 Nitin Dahyabhai 2019-09-10 16:10:16 EDT

Danny, are you preparing release and review materials?

Comment 2 Danny Ju 2019-09-18 20:13:18 EDT

Hi Nitin,
Apologize for the delay. Was tied up bu some other work.

I created review plan and requested review at:  
https://projects.eclipse.org/projects/webtools.glassfish-tools/releases/1.0.1

Comment 3 David Williams 2019-09-24 15:22:16 EDT

To release it is fine, but I am not sure a release review is needed for a minor release -- especially since, as stated in release review documentation, "There are no API or implementation changes in release 1.0.1. Just a few required Maven build script updates after migrating to new CI infrastructure at https://ci-staging.eclipse.org/glassfish-tools/".

But, guess it doesn't hurt to document "what's changed", so that's goodness. 
Thanks,

Comment 4 Wayne Beaton 2019-09-25 16:27:05 EDT

(In reply to David Williams from comment #3)
> To release it is fine, but I am not sure a release review is needed for a
> minor release.

A review is not required for a *service release* (which is what I think you're describing). Any release that adds functionality or otherwise includes significant changes would be considered either a major or minor release and would require a review. Note that the EDP was changed in late 2018 to allow a project to engage in major and minor releases for an entire year after engaging in a successful release review. Please also note that all intellectual property that is contained in any release (regardless of whether or not a review is required) must be fully vetted by the IP Due Diligence process.

Comment 5 David Williams 2019-09-27 13:45:47 EDT

(In reply to Wayne Beaton from comment #4)
> (In reply to David Williams from comment #3)
> > To release it is fine, but I am not sure a release review is needed for a
> > minor release.
> 
> A review is not required for a *service release* (which is what I think
> you're describing). Any release that adds functionality or otherwise
> includes significant changes would be considered either a major or minor
> release and would require a review. Note that the EDP was changed in late
> 2018 to allow a project to engage in major and minor releases for an entire
> year after engaging in a successful release review. Please also note that
> all intellectual property that is contained in any release (regardless of
> whether or not a review is required) must be fully vetted by the IP Due
> Diligence process.

Thanks for the correction on terminology, Wayne (how quickly we forget :), and the updated on new rules.

Comment 6 Cydnie Smith 2019-10-07 12:23:43 EDT

As this was declared a service release, no formal review is required. Please ensure that all intellectual property is fully vetted by the IP Due Diligence process. 

I declare this bug resolved. 

If you have any questions, please don't hesitate to let us know!