Bug 54968 - [javadoc][select] ICodeAssist#codeSelect doesn't work for member references in javadoc
Summary: [javadoc][select] ICodeAssist#codeSelect doesn't work for member references i...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 M6   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 38833 72192 75120 75919 87747 88587 (view as bug list)
Depends on:
Blocks: 30478
  Show dependency tree
 
Reported: 2004-03-16 11:13 EST by Markus Keller CLA
Modified: 2005-03-30 15:10 EST (History)
9 users (show)

See Also:

Attachments
Patch for the implementation of this functionality (24.52 KB, patch)
2005-03-18 09:22 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2004-03-16 11:13:56 EST 
I20040310:

/** @see #method() */
void method() {
	method();
}

- set the caret into #method() and hit F3 -> beep, not found
- set the caret into method(); and hit F3 -> opens declaration

ICodeAssist#codeSelect works for type references in javadocs, but not for
members. To watch it, set a breakpoint in
SelectionConverter#codeResolve(IJavaElement, ITextSelection) and press F3.
Comment 1 David Audel CLA 2004-05-11 12:25:55 EDT 
Currently code select work for type with a kind of trick.
If no proposals are founds then we try to find a type with the same name as 
the selection token.

To be able to perform methods code selection we need to add a real javadoc 
support.
  - new ast selection node for javadoc
  - overiding of JavadocParser
  - improvement of inference code of SelectionEngine

To risky to do that before 3.0

Post 3.0
Comment 2 Dani Megert CLA 2004-08-20 09:13:55 EDT 
*** Bug 72192 has been marked as a duplicate of this bug. ***
Comment 3 Dani Megert CLA 2004-08-20 09:14:02 EDT 
*** Bug 22043 has been marked as a duplicate of this bug. ***
Comment 4 Dani Megert CLA 2004-08-20 09:14:23 EDT 
*** Bug 38833 has been marked as a duplicate of this bug. ***
Comment 5 Dani Megert CLA 2004-09-28 03:36:44 EDT 
Can this be reopened for 3.1?
Comment 6 Dani Megert CLA 2004-09-28 03:36:49 EDT 
*** Bug 75120 has been marked as a duplicate of this bug. ***
Comment 7 David Audel CLA 2004-09-28 05:07:23 EDT 
Reopened for 3.1.
Comment 8 Dani Megert CLA 2004-10-11 05:39:19 EDT 
*** Bug 75919 has been marked as a duplicate of this bug. ***
Comment 9 Dani Megert CLA 2005-03-11 05:33:44 EST 
I'd really like to see this fixed.
Comment 10 Dani Megert CLA 2005-03-11 05:33:48 EST 
*** Bug 87747 has been marked as a duplicate of this bug. ***
Comment 11 Frederic Fusier CLA 2005-03-18 09:22:16 EST 
Created attachment 18976 [details]
Patch for the implementation of this functionality
Comment 12 Frederic Fusier CLA 2005-03-18 10:11:51 EST 
Fixed.

Now code selection is allowed in Javadoc wherever a reference can be specified.
That means @see, @link, @linkplain, @throws, @exception, @param and @value tags.

[jdt-core-internal]
Test cases created in new classes:
 - org.eclipse.jdt.core.tests.compiler.parser.SelectionJavadocTests
 - org.eclipse.jdt.core.tests.model.SelectionJavadocModelTests
Comment 13 Dani Megert CLA 2005-03-21 03:39:43 EST 
*** Bug 88587 has been marked as a duplicate of this bug. ***
Comment 14 Nick Edgar CLA 2005-03-21 11:06:36 EST 
Nice, thanks.
Comment 15 Olivier Thomann CLA 2005-03-30 15:10:42 EST 
Verified in I20050330-0500