Description Alexander Kriegisch 2019-07-20 01:36:51 EDT

Created attachment 279347 [details]
Sample code

This scenario works nicely:
https://stackoverflow.com/a/48543096/1082681

But this one does not:
https://stackoverflow.com/q/57005199/1082681

Here is some code adapted from the second link that should work but does not:

------------------------------------------------------------

package de.scrum_master.app;

import java.lang.annotation.ElementType;
import java.lang.annotation.Inherited;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;

@Target(value = {ElementType.TYPE, ElementType.METHOD})
@Retention(RetentionPolicy.RUNTIME)
@Inherited
public @interface Annotation2 {}

------------------------------------------------------------

package de.scrum_master.app;

import java.lang.annotation.ElementType;
import java.lang.annotation.Inherited;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
@Inherited
@Annotation2
public @interface Annotation1 {}

------------------------------------------------------------

package de.scrum_master.app;

@Annotation1
abstract class BaseService {}

------------------------------------------------------------

package de.scrum_master.app;

import java.lang.annotation.Annotation;

//@Annotation1
public class TestService extends BaseService {
  private void testMethod() {
    System.out.println("Doing something");
  }

  public static void main(String[] args) {
    System.out.println("Annotations found on class TestService:");
    for (Annotation annotation : TestService.class.getAnnotations())
      System.out.println("  " + annotation);

    new TestService().testMethod();
  }
}

------------------------------------------------------------

package de.scrum_master.aspect;

import org.aspectj.lang.JoinPoint;
import org.aspectj.lang.annotation.Aspect;
import org.aspectj.lang.annotation.Before;

@Aspect
public class TestAspect {
  @Before(
    "execution(* *(..)) && (" +
      "within(@de.scrum_master.app.Annotation2 *) || " +
      "within(@(@de.scrum_master.app.Annotation2 *) *) || " +
      "within(@(@(@de.scrum_master.app.Annotation2 *) *) *)" +
    ")"
  )
  public void myAdvice1(JoinPoint joinPoint) {
    System.out.println(joinPoint);
  }

  @Before(
    "execution(* (@de.scrum_master.app.Annotation2 *)+.*(..)) || " +
    "execution(* (@(@de.scrum_master.app.Annotation2 *) *)+.*(..)) || " +
    "execution(* (@(@(@de.scrum_master.app.Annotation2 *) *) *)+.*(..))"
  )
  public void myAdvice2(JoinPoint joinPoint) {
    System.out.println(joinPoint);
  }
  
}

------------------------------------------------------------

The console log when running TestService.main(..) is:

Annotations found on class TestService:
  @de.scrum_master.app.Annotation1()
Doing something

I.e. TestService does indeed inherit the (meta-annotated) annotation from BaseService but AspectJ pointcut matching does not work.

------------------------------------------------------------

Now if I uncomment the annotation @Annotation1 directly in TestService, it works as I would have expected with the inherited annotation already:

execution(void de.scrum_master.app.TestService.main(String[]))
execution(void de.scrum_master.app.TestService.main(String[]))
Annotations found on class TestService:
  @de.scrum_master.app.Annotation1()
execution(void de.scrum_master.app.TestService.testMethod())
execution(void de.scrum_master.app.TestService.testMethod())
Doing something

The same annotation is found on TestService and suddenly both advices get triggered.