Bug 54927 - VerticalPlacement should take a flag in it's constructor that determines whether the height of the nodes should be changed
Summary: VerticalPlacement should take a flag in it's constructor that determines whet...
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Draw2d (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-15 20:12 EST by Sean Woodhouse CLA
Modified: 2006-11-22 10:29 EST (History)
2 users (show)

See Also:


Attachments
source (1.63 KB, text/plain)
2004-03-15 20:15 EST, Sean Woodhouse CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Woodhouse CLA 2004-03-15 20:12:48 EST
Currently org.eclipse.draw2d.internal.graph.VerticalPlacement will resize the 
height of the nodes to be the height of the biggest node in the row. This 
behaviour should really selectable. I suggest adding a boolean flag to the 
constructor to enable or disable this behaviour.
Comment 1 Sean Woodhouse CLA 2004-03-15 20:15:26 EST
Created attachment 8591 [details]
source
Comment 2 Randy Hudson CLA 2004-05-01 20:03:22 EDT
This class is currently internal.  What would you propose for an [open-ended] 
set of layout hints on both the Nodes and the DirectedGraph?
Comment 3 Sean Woodhouse CLA 2004-05-02 19:43:54 EDT
I'd suggest adding a mechanism on DirectedGraphLayout.visit() method to 
specify how you want the graph laid out. These could be defined by a 'style' 
flag, or a dictionary of layout directives. The characteristics you can change 
will really be determined by the implementation of the visit() method, so a 
dictionary might be the better implementation. 

You could also apply these directives to each node and edge, but I would 
assume in most cases you'd want the same directives to apply across all nodes 
and edges for a particular layout invocation. Hence my suggestion to put it on 
DirectedGraphLayout.