Bug 549243 - [13] support --add-modules ALL-MODULE-PATH
Summary: [13] support --add-modules ALL-MODULE-PATH
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-07-13 14:08 EDT by Stephan Herrmann CLA
Modified: 2020-06-05 18:05 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2019-07-13 14:08:56 EDT 
There's an addition to --add-modules: https://bugs.openjdk.java.net/browse/JDK-8222396

We need to check whether this is relevant for JDT, see the mentioning of "compiling in multi-module mode".
Comment 1 Stephan Herrmann CLA 2019-07-13 14:09:56 EDT 
The JDK ticket has been approved for 13.
Comment 2 Stephan Herrmann CLA 2019-11-14 12:39:05 EST 
Support for launching with ALL-MODULE-PATH was added via bug 498044.

During compilation an explicit add-reads can serve as a workaround. Postponing.

To see the problem:
- create a non-modular project P at 9+
- add a regular jar J to the module path
  - let the current project patch J (as automatic module)
- add a modular jar M to the module path
- try to reference classes from M inside sources of P
=> not accessible
+ workaround: let J read M

=> it should be possible to achieve the same (and for all modules) using add-reads ALL-MODULE-PATH.
Comment 3 Stephan Herrmann CLA 2020-02-27 18:49:57 EST 
Bulk move to 4.16
Comment 4 Stephan Herrmann CLA 2020-05-18 18:46:30 EDT 
Bulk move of unassigned bugs to 4.17