Community
Participate
Working Groups
Windows launchers needs to be signed once the icon replacement is done. pde can use signing service described here https://wiki.eclipse.org/IT_Infrastructure_Doc#CBI_Maven_signing_plugin
What are the steps to recreate this in PDE?
(In reply to Vikas Chandra from comment #1) > What are the steps to recreate this in PDE? Since this is enhancement there are no reproducible steps to recreate. Take an example rcp project and export it using product configuration. In the repository generated you'll see binary folder this contains executables in zip format containing eclipse.exe and eclipsec.exe. These needs to be signed.
Created attachment 279174 [details] Sample application Open TestAppFeature project. Export product to generate repository Verify the executable in repo/binary. it will say signature not valid.
Worked with Sravan on couple of approaches 1) BrandingIron from pde.build calls p2.publisher and p2.publisher.eclipse and there the signing is removed. Tried running "curl" command from code (hit few roadblocks) - also not a good way and also not sure if that would actually work in the nightly build eclipse case. 2) Jar signing code flow - ModelBuildScriptGenerator::setSignJars seems to sign the jar. However with the attached application, that code flow is not taken. For this case, more investigation is required and how the nightly build calls pde.build/p2.publisher/p2.publisher.eclipse needs to be more clear for getting a solution. It'll be helpful if someone who has some expertise in this area can comment or provide inputs.
Sent email here - https://www.eclipse.org/lists/cross-project-issues-dev/msg16903.html But no response.
Sravan, Vikas, what's the status and further plan here?
I've removed the 'plan' keyword because no target milestone was set. A plan bug must always have a target milestone. If you consider to set the 'plan' keyword again, make sure that the target milestone must match the release where it was originally planned. If the work was not finished, a follow-up plan bug for the next release must be created and the old one left in the NEW state. Not doing so would destroy the initial plan. The plan must reflect what has been delivered and what not. Also, please make sure that you only tag root/top-level bugs with 'plan'. Bug fixes or simple things must not get the 'plan keyword.
New Gerrit change created: https://git.eclipse.org/r/161625
Can we target this for 4.16? Vikas or Sravan, one of you needs to own this bug.
Is there a way to turn off signing windows launchers in the PDE build?
