Community
Participate
Working Groups
I just managed to double click the "Commit and Push" button, having two push wizards open as a result. We need to disable those buttons earlier.
Would disabling them immediately on "click" be an option? (The question is, whether subsequent enablement checks work as expected) Also, would it make sense to turn "Commit and Push" into "Push" if there is nothing to commit? I sometimes commit and then think that commit and push would have been OK. Currently "Commit and Push" then complains that there is nothing to commit and you have to push from a different location.
New Gerrit change created: https://git.eclipse.org/r/159167
As noted by Thomas Wolf, this bug is closely related (99% duplicate) of bug 525685. I'd claim that the gerrit change resolves both. The re-interpretation of the "Commit and Push" button to "Push" in case there is nothing to commit is not addressed.
@Michael: could you please check whether the fix for bug 525685 also solves this double-click problem? If so, I suggest we close this as a duplicate.
I had this issue again at some point in the last 2 weeks, so I'm somewhat sure it's not fixed (since I use egit nightly in all installations). Looking at the code, I see the commit buttons being enabled/disabled in 2 methods of the staging view _after_ quite some other code has been executed, and that code may even access the disk, since it checks all kinds of conditions of the repository, index state etc. This would fit my observation that this error only happens when eclipse is "under stress", e.g. a clean build running in parallel to my attempt of committing. To really avoid this, we would need to immediately disable the buttons on click, and then enable them again after all those conditions have been checked, as suggested by Alexander.
