Bug 548761 - Incremental validation update listener
Summary: Incremental validation update listener
Status: CLOSED FIXED
Alias: None
Product: ECP
Classification: Modeling
Component: Validation (show other bugs)
Version: 1.21.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.22.0   Edit
Assignee: Christian Damus CLA
QA Contact: Eugen Neufeld CLA
URL:
Whiteboard:
Keywords: api, noteworthy
Depends on:
Blocks:
 
Reported: 2019-06-28 10:19 EDT by Christian Damus CLA
Modified: 2019-07-17 19:23 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2019-06-28 10:19:11 EDT
The ValidationService (the view-model service, not the ad hoc service) provides a listener protocol that reports, after a validation occurred, the current "validation result".  This validation result is the set of Diagnostics attached to the root of the view model (the top VView).

That is fine for applications that don't throttle the presentation of validation problems.  For applications that do, the root view model element will not have all of the diagnostics.  It will only have up to the defined limit and, if necessary, one more problem that's a placeholder indicating to the user that there are other unreported problems.

For applications that present validation problems in some other visualization besides decorations within the editor (for example, a dedicate view part), there is no easy way to get the set of all validation problems:  listening to the validation service cannot provide all of the problems and nor can scraping the VDiagnostics attached to the view model.  During the processing of the validation queue, the ValidationService does have a complete picture of the validation state of all of the objects that it validated.  This is the case both for the initial full validation of the model and any incremental validation updates.  A new incremental update listener protocol would be of value to help applications maintain a complete view of the validation state of the model.
Comment 1 Eclipse Genie CLA 2019-06-28 11:29:26 EDT
New Gerrit change created: https://git.eclipse.org/r/145124
Comment 3 Christian Damus CLA 2019-06-28 16:31:11 EDT
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/145124 was merged to [develop].
Comment 4 Christian Damus CLA 2019-07-17 19:23:20 EDT
Fix published in 1.22 M2.