Bug 548253 - with the rcptt maven plugin, if 'skipTags' ends with a semicolon, 'tests' does not work
Summary: with the rcptt maven plugin, if 'skipTags' ends with a semicolon, 'tests' doe...
Status: UNCONFIRMED
Alias: None
Product: RCPTT
Classification: Technology
Component: Runner (show other bugs)
Version: 2.4.2   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Vasili Gulevich CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-13 15:01 EDT by Gene Smith CLA
Modified: 2019-06-13 15:01 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gene Smith CLA 2019-06-13 15:01:09 EDT
When the rcptt runner parses arguments passed by the rcptt maven plugin, if a splitable argument ends with the separator, it eats the next argument without telling the user what happened.

I have a list of "skipTags", which is collected by adding several other lists together.  And if the last list is empty, the collected list ends with a semicolon.

When that happens, the code:
    https://git.eclipse.org/c/rcptt/org.eclipse.rcptt.git/tree/runner/org.eclipse.rcptt.runner/src/org/eclipse/rcptt/runner/RunnerConfiguration.java#n591
causes "skipTags" to eat the text value meant for "tests".  And the output of the runner does NOT show that it added "tests" to "skipTags" and does NOT show that it thinks "tests" is empty.  It in fact logs a warning that "tests" is invalid, but shows the valid value for in the message.

After I identified this, I was able to add a simple work around in my pom (I use the maven plugin), so for me this is a very minor bug:
  <skipTags>
    <!-- if the runner sees a semi-colon at the end of this list, it will eat the argument meant for "tests" -->
    <skipTag>${skip.tags};_do_not_end_with_a_semicolon_</skipTag>
  </skipTags>