Comment 1 Michael Fraenkel 2004-04-02 17:55:48 EST

Created attachment 9172 [details]
Interface cast detection

There were at least two places both dealing with casting to an interface which
were not detecting unnecessary casts.  Is it necessary to perform the runtime
checkcast when you know that the two types are compatible?  In one case, I left
the checkcast in and the other I removed it since I wasn't sure which was
correct.  But overall I think the idea is correct.

Comment 2 Philipe Mulet 2004-04-04 09:23:49 EDT

Thanks for investigating Michael, you were on the right track. Our casting 
check was not correct; and we issued more checkcast instructions than we should 
have in this case. Fixed both class->interface and interface->interface 
scenario, and instanceof + equal expression checks.

Added regression test: CastTest#test033.

Comment 3 Philipe Mulet 2004-04-04 10:05:25 EDT

Fix implemented in both HEAD and JDK_1_5 streams.

Comment 4 Olivier Thomann 2004-05-18 13:48:09 EDT

Verified in 200405180816