Bug 547579 - Combine "Remove Repository from View" and "Delete Repository" menu entries
Summary: Combine "Remove Repository from View" and "Delete Repository" menu entries
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-23 05:49 EDT by Lars Vogel CLA
Modified: 2021-01-21 04:02 EST (History)
4 users (show)

See Also:


Attachments
Screenshot (19.94 KB, image/png)
2019-05-23 05:49 EDT, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-05-23 05:49:47 EDT
Created attachment 278712 [details]
Screenshot

Both "Remove Repository from View" and "Delete Repository" menu entries are IMHO relative rare operation. I suggest to combine them in one dialog trigger by a menu entry similar to "Remove Repository" and offer a option "Delete Git repository on disk" option on the dialog.

Same as we do on the "Delete project" dialog. See screesshot
Comment 1 Thomas Wolf CLA 2019-05-23 09:30:44 EDT
(In reply to Lars Vogel from comment #0)
> combine them in one dialog
> trigger by a menu entry similar to "Remove Repository" and offer a option
> "Delete Git repository on disk" option on the dialog.

That already exists. Hit the delete key with a repo node selected :-)

Someone apparently thought it would be useful to give the user both possibilities in the context menu.
Comment 2 Michael Keppler CLA 2019-05-25 02:37:41 EDT
I thought something similar several times when using the menus. I'm also in favor of having only one menu item there to reduce the used space, since those are seldomly used.

The solution with the minimum effort would be to remove both menu items (to no longer target the similarly named commands) and to add a new one labeled "Remove repository" that invokes the handler currently used for delete. There is just one drawback: This new menu item and the existing command "Remove repository" would do different things, although having the same name. Anyone with a better name?

One could still argue about combining the 2 dialogs (remove or delete - how to delete) into one, but I find the current workflow with 2 dialogs more easy to understand for end users.
Comment 3 Lars Vogel CLA 2019-05-25 03:03:02 EDT
(In reply to Michael Keppler from comment #2)
> I thought something similar several times when using the menus. I'm also in
> favor of having only one menu item there to reduce the used space, since
> those are seldomly used.
> 
> The solution with the minimum effort would be to remove both menu items (to
> no longer target the similarly named commands) and to add a new one labeled
> "Remove repository" that invokes the handler currently used for delete.
> There is just one drawback: This new menu item and the existing command
> "Remove repository" would do different things, although having the same
> name. Anyone with a better name?
> 
> One could still argue about combining the 2 dialogs (remove or delete - how
> to delete) into one, but I find the current workflow with 2 dialogs more
> easy to understand for end users.

+1