Bug 547206 - Make API Tools comparator available as Application
Summary: Make API Tools comparator available as Application
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.12 M3   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation, noteworthy
Depends on:
Blocks: 474156
  Show dependency tree
 
Reported: 2019-05-13 05:08 EDT by Mickael Istria CLA
Modified: 2019-06-03 02:07 EDT (History)
5 users (show)

See Also:

Attachments
somewhere here (65.03 KB, image/jpeg)
2019-05-20 06:36 EDT, Vikas Chandra CLA 		no flags Details
Another test gerrit (7.94 KB, patch)
2019-05-21 11:12 EDT, Vikas Chandra CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mickael Istria CLA 2019-05-13 05:08:29 EDT 
To ease inclusion in non-Ant builds (such as Tycho), it would be convenient to make the API Tools comparator for a specific bundle available as an Application.
Comment 1 Eclipse Genie CLA 2019-05-15 08:54:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/142154
Comment 2 Eclipse Genie CLA 2019-05-16 12:42:19 EDT 
New Gerrit change created: https://git.eclipse.org/r/142274
Comment 3 Eclipse Genie CLA 2019-05-17 11:19:33 EDT 
New Gerrit change created: https://git.eclipse.org/r/142341
Comment 5 Vikas Chandra CLA 2019-05-20 05:38:27 EDT 
Will test this in tomorrow's build and then will update the N&N.
Comment 6 Mickael Istria CLA 2019-05-20 06:30:05 EDT 
Thanks Vikas!
About documentation, how should it be added? Ie in which section?
Comment 7 Vikas Chandra CLA 2019-05-20 06:36:08 EDT 
Created attachment 278660 [details]
somewhere here
Comment 8 Vikas Chandra CLA 2019-05-21 02:55:05 EDT 
Can the bug submitter/bug assignee please verify this defect for 4.12 M3?
Comment 9 Vikas Chandra CLA 2019-05-21 11:12:08 EDT 
Created attachment 278681 [details]
Another test gerrit

Can someone make a gerrit patch out of this to see if this fails as expected.

For some reason I am unable to create a gerrit change ( in platform UI)
Comment 10 Eclipse Genie CLA 2019-05-21 12:25:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/142535
Comment 11 Mickael Istria CLA 2019-05-21 12:46:12 EDT 
(In reply to Vikas Chandra from comment #9)
> Can someone make a gerrit patch out of this to see if this fails as expected.

See https://git.eclipse.org/r/142535
It fails on CI because some other features don't like the major version upgrade.
If I run it locally from inside the `bundles/org.eclipse.jface.databinding` folder with `mvn clean verify -Pbuild-individual-bundles`, I get a BUILD SUCCESSFUL, looking into the .log file, I see an error caused by the workspace dir being under the project dir. So I've updated the patch (pushed Patch Set 2 to Gerrit) and I now get a build failure with the same command

```
1 API ERRORS
* Marker [on: /org.eclipse.jface.databinding/META-INF/MANIFEST.MF, id: 4, type: org.eclipse.pde.api.tools.version_numbering, attributes: [apiMarkerID: 4, charEnd: 155, charStart: 140, description: , lineNumber: 5, message: The major version should be the same for version 2.0.0, since no API breakage occurred since version 1.9.0, messagearguments: 2.0.0#1.9.0, problemid: 925892614, severity: 2, sourceId: API Tools, version: 1.9.0.qualifier], created: 5/21/19, 6:45 PM]
1 API warnings
* Marker [on: /org.eclipse.jface.databinding, id: 5, type: org.eclipse.pde.api.tools.api_usage, attributes: [apiMarkerID: 3, charEnd: -1, charStart: -1, lineNumber: 0, message: Execution environment references were not checked for 'org.eclipse.jface.databinding' because no environment descriptions are installed. , messagearguments: org.eclipse.jface.databinding, problemid: 665845798, severity: 1, sourceId: API Tools], created: 5/21/19, 6:45 PM]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
```
Comment 13 Eclipse Genie CLA 2019-05-22 12:11:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/142607
Comment 14 Vikas Chandra CLA 2019-05-23 12:01:52 EDT 
(In reply to Eclipse Genie from comment #13)
> New Gerrit change created: https://git.eclipse.org/r/142607

I will commit this for 4.12Rc1
Comment 16 Andrey Loskutov CLA 2019-05-25 02:46:09 EDT 
(In reply to Vikas Chandra from comment #14)
> (In reply to Eclipse Genie from comment #13)
> > New Gerrit change created: https://git.eclipse.org/r/142607
> 
> I will commit this for 4.12Rc1

That causes test fail due wrong link: Invalid link in "/org.eclipse.pde.doc.user/topics_Reference.xml": reference/api-tooling/applications/analysis-application.html 

https://download.eclipse.org/eclipse/downloads/drops4/I20190524-1800/testresults/html/org.eclipse.ua.tests.doc_ep412I-unit-cen64-gtk3-java8_linux.gtk.x86_64_8.0.html

I will push a fix in a moment.
Comment 17 Eclipse Genie CLA 2019-05-25 02:47:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/142774
Comment 19 Dani Megert CLA 2019-05-27 03:42:56 EDT 
Thanks for the fix Andrey.

I've reset the target milestone to M3 since the feature itself was delivered there and is in the N&N.
Comment 20 Lakshmi P Shanmugam CLA 2019-06-03 02:07:19 EDT 
(In reply to Eclipse Genie from comment #12)
> Gerrit change https://git.eclipse.org/r/142274 was merged to [master].
> Commit:
> http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=d899cad599d7a42b6a9a601a519337de574a4111
> 

This news entry has long lines in multiple <pre> tags causing the title column in the PDE N&N page to become very narrow. 

Fixed the narrow column by modifying the entry:

https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=e4bd6d3ae7274a67b0ed9a9c6d47a2022eebba4e
https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=fe965d911400cfda51484a37cd4a94680104b83e