Community
Participate
Working Groups
Currently it is required to open category.xml with some general editor to control all the changes explicitly. Category Manifest editor should have "Source" tab like Target editor.
New Gerrit change created: https://git.eclipse.org/r/141715
Gerrit change https://git.eclipse.org/r/141715 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=a4cf9d78a54271df5bda969a8f4a9b84f4ec6b65
Thanks, Alexander.
@Julian N&N?
(In reply to Alexander Fedorov from comment #4) > @Julian N&N? Yes, please ;)
Whenever I click on Source tab and then click on the other 2 tabs, the editor shows as dirty.
(In reply to Vikas Chandra from comment #6) > Whenever I click on Source tab and then click on the other 2 tabs, the > editor shows as dirty. I've had that issue as well when I used a 4.11 target platform. I'll re-check that tomorrow with an I-Build.
(In reply to Julian Honnen from comment #7) > (In reply to Vikas Chandra from comment #6) > > Whenever I click on Source tab and then click on the other 2 tabs, the > > editor shows as dirty. > > I've had that issue as well when I used a 4.11 target platform. I'll > re-check that tomorrow with an I-Build. I think it is not related with the patch, one need to click the second tab "Repository Properties"
>> one need to click the second tab "Repository Properties" Yes but once you save it, that problem doesn't happen again. But in this case, dirty mark comes every single time when you click on source.
(In reply to Vikas Chandra from comment #9) > >> one need to click the second tab "Repository Properties" > > Yes but once you save it, that problem doesn't happen again. > > But in this case, dirty mark comes every single time when you click on > source. I still think that added "Source" tab just highlighted the existing problem: added Bug 547088 to track
>>I still think that added "Source" tab just highlighted the existing problem I have fixed the scenario where the dirty mark issue was very visible post this change. The old problem still exists but it is only a 1 time event when stats are being set on that particular tab. It can also be seen as a 1 time initialization for that tab. I still think that it is a bug but it is a pre-existing bug Can you test in tomorrow's I build if everything is working fine.
(In reply to Vikas Chandra from comment #11) > >>I still think that added "Source" tab just highlighted the existing problem > > I have fixed the scenario where the dirty mark issue was very visible post > this change. The old problem still exists but it is only a 1 time event when > stats are being set on that particular tab. It can also be seen as a 1 time > initialization for that tab. I still think that it is a bug but it is a > pre-existing bug > > Can you test in tomorrow's I build if everything is working fine. I20190508-1800 no longer has a dirty marker when switching between source and category definition.
(In reply to Julian Honnen from comment #12) > (In reply to Vikas Chandra from comment #11) > > >>I still think that added "Source" tab just highlighted the existing problem > > > > I have fixed the scenario where the dirty mark issue was very visible post > > this change. The old problem still exists but it is only a 1 time event when > > stats are being set on that particular tab. It can also be seen as a 1 time > > initialization for that tab. I still think that it is a bug but it is a > > pre-existing bug > > > > Can you test in tomorrow's I build if everything is working fine. > > I20190508-1800 no longer has a dirty marker when switching between source > and category definition. The problem exists in I20190508-1800. Do you have latest PDE code by any chance and then testing on the launched version. I have put a fix which fixes "dirty marker when switching between source and category definition"
Sorry, I thought your fix was already in I20190508-1800. I still don't get the dirty marker from source tab (only from repository properties), not on I20190508-1800 nor with latest sources. Also no marker when I comment out your changes.
Created attachment 278551 [details] gif showing the image Note that I save the file after seeing dirty mark using control S to show further problems exists whether or not you go to 1st tab or 2nd tab after clicking source tab
Ah, you have to activate repository properties once to trigger the bug. After that switching between source and category def will make the editor dirty (without your fix). With the fix it works.
New Gerrit change created: https://git.eclipse.org/r/142091
Gerrit change https://git.eclipse.org/r/142091 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=d4f137d09a127a0f3f72153a5c6d5b3ac810edbc
Can the bug submitter/bug assignee please verify this defect for 4.12 M3?
Eclipse SDK Version: 2019-06 (4.12) Build id: I20190520-1805 OS: Windows 10, v.10.0, x86_64 / win32 Java version: 1.8.0_211
