Community
Participate
Working Groups
This fails on gerrit too configureProjectAndCheckMarkers[19] configureProjectAndCheckMarkers[18] configureProjectAndCheckMarkers[17] configureProjectAndCheckMarkers[19] Failure Template 'OSGi EventAdmin Service Example' generates errors.: array lengths differed, expected.length=0 actual.length=1 java.lang.AssertionError: Template 'OSGi EventAdmin Service Example' generates errors.: array lengths differed, expected.length=0 actual.length=1 at org.junit.Assert.fail(Assert.java:88) at org.junit.internal.ComparisonCriteria.assertArraysAreSameLength(ComparisonCriteria.java:76) at org.junit.internal.ComparisonCriteria.arrayEquals(ComparisonCriteria.java:37) at org.junit.Assert.internalArrayEquals(Assert.java:532) at org.junit.Assert.assertArrayEquals(Assert.java:283) at org.eclipse.pde.ui.templates.tests.TestPDETemplates.configureProjectAndCheckMarkers(TestPDETemplates.java:181) at sun.reflect.GeneratedMethodAccessor35.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
This started happening post https://bugs.eclipse.org/bugs/show_bug.cgi?id=544924#c19 Peter, any idea what is happening here?
How exactly are you able to reproduce it? I can change the templates to disable automatic addition of DS annotations to classpath, it shouldn't be necessary.
(In reply to Peter Nehrer from comment #2) > How exactly are you able to reproduce it? I can change the templates to > disable automatic addition of DS annotations to classpath, it shouldn't be > necessary. The type st fails in our official SDK builds, see for example https://download.eclipse.org/eclipse/downloads/drops4/I20190427-1800/testResults.php
(In reply to Peter Nehrer from comment #2) > How exactly are you able to reproduce it? I can change the templates to > disable automatic addition of DS annotations to classpath, it shouldn't be > necessary. Create any patch for PDE and push it- Gerrit build will fail with 3 fails, like this one below: https://ci.eclipse.org/pde/job/eclipse.pde.ui-Gerrit/1524/testReport/junit/org.eclipse.pde.ui.templates.tests/TestPDETemplates/configureProjectAndCheckMarkers_17_/ Peter: please provide fix ASAP, it is not acceptable that tests are failing for so long time, it is blocking everyone contributing to PDE.
New Gerrit change created: https://git.eclipse.org/r/141390
New Gerrit change created: https://git.eclipse.org/r/141393
Gerrit change https://git.eclipse.org/r/141390 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=22b6e51bb680aae3f57f3236bc6d6303a8b32344
>>I can change the templates to disable automatic addition of DS annotations to >>classpath If no other solution is possible, then we can go for this workaround.
New Gerrit change created: https://git.eclipse.org/r/141663
Gerrit change https://git.eclipse.org/r/141663 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=6f96965af7bdf596d62e9aa41b20ba98576696af
Thanks Peter!
I still get this issue.
May be this is resolved as after rebasing, I didn't get this. I will check on some more gerrit changes to confirm.
New Gerrit change created: https://git.eclipse.org/r/142127
Gerrit change https://git.eclipse.org/r/142127 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e4a4c956865a93dfad7faf1e932f00c0dffd5dc4
(In reply to Eclipse Genie from comment #10) > Gerrit change https://git.eclipse.org/r/141663 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=6f96965af7bdf596d62e9aa41b20ba98576696af > Reverted as this destroys the fix for bug 544924 and causes a build path error in my workspace.
(In reply to Dani Megert from comment #16) > (In reply to Eclipse Genie from comment #10) > > Gerrit change https://git.eclipse.org/r/141663 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=6f96965af7bdf596d62e9aa41b20ba98576696af > > > Reverted as this destroys the fix for bug 544924 and causes a build path > error in my workspace. Please provide details for those errors when you revert commits.
(In reply to Julian Honnen from comment #17) > (In reply to Dani Megert from comment #16) > > (In reply to Eclipse Genie from comment #10) > > > Gerrit change https://git.eclipse.org/r/141663 was merged to [master]. > > > Commit: > > > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=6f96965af7bdf596d62e9aa41b20ba98576696af > > > > > Reverted as this destroys the fix for bug 544924 and causes a build path > > error in my workspace. > > Please provide details for those errors when you revert commits. I did. It invalidated the fix for bug 544924. Summary: For org.eclipse.e4.ui.workbench.swt (in my workspace as source) an invalid (well non-existent) annotations.jar was added to the build path instead of /org.eclipse.pde.ds.lib/annotations.jar (also in my workspace as source).
>>can change the templates to > disable automatic addition of DS annotations to classpath Peter, Can we do this as a temporary solution
We need urgent some solution here. Contributing to PDE via Gerrit is blocked - there are NO successful builds anymore due this bug, just look at this misery: https://ci.eclipse.org/pde/job/eclipse.pde.ui-Gerrit/.
I hope to provide some workaround patch here later today. Meanwhile we can override the 3 gerrit failures for any PDE code commit.
(In reply to Vikas Chandra from comment #21) > I hope to provide some workaround patch here later today. > > Meanwhile we can override the 3 gerrit failures for any PDE code commit. I will do this for 4.12 RC1
New Gerrit change created: https://git.eclipse.org/r/142571
Gerrit change https://git.eclipse.org/r/142571 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=fc8a9cf851038fd4632e7d31d51d92013428ad9f
See to work these days. https://download.eclipse.org/eclipse/downloads/drops4/I20200330-1800/testResults.php Vikas, please reopen if you still see these errors.
