Bug 546655 - Unnecessary "Pull was canceled" dialog after I press cancel in the progress view
Summary: Unnecessary "Pull was canceled" dialog after I press cancel in the progress view
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2019-04-23 06:32 EDT by Lars Vogel CLA
Modified: 2019-04-26 11:40 EDT (History)
2 users (show)

See Also:

Attachments
Screencast (3.53 MB, image/gif)
2019-04-23 06:32 EDT, Lars Vogel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-04-23 06:32:55 EDT 
Created attachment 278361 [details]
Screencast

If I press cancel during a pull operation I get a "Pull was canceled" dialog which is of course unnecessary. We expect that so no additional user dialog is needed.

See screencast.
Comment 1 Michael Keppler CLA 2019-04-26 11:15:34 EDT 
I tend to agree, that we can remove that message. What about other developers?

If we remove this, there are at least 6 operations using "was canceled" messages. Also the multi pull operation result should be inspected further, since it uses an _error_ dialog, if some of the nested pull operations are canceled.
Comment 2 Lars Vogel CLA 2019-04-26 11:40:31 EDT 
AFAICS no other operation which is cancelled shows a confirmation dialog. For example,  start a clean build and cancel.

We also do not show a "Save successful" dialog after we press save. ;-)