Bug 54625 - Incremental support does not work with outjar
Summary: Incremental support does not work with outjar
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: 1.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.2   Edit
Assignee: Adrian Colyer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-12 09:43 EST by Adrian Colyer CLA
Modified: 2004-03-19 09:41 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Colyer CLA 2004-03-12 09:43:12 EST 
Either fix the class file deleting etc. to work with jars, or always do a batch 
build when working with outjars.
Comment 1 Adrian Colyer CLA 2004-03-16 10:17:52 EST 
zip files don't support adding or updating files in an existing jar (you need to 
take a copy and move everything across). This can be done, but is a bit of work. 
I'm reluctant to do it because the test harness does not support both 
incremental and outjar at the same time (and it was getting too difficult to 
make it work effectively) so I can't write a good test suite around it. 
Therefore for 1.2 I've added a simple test in AjState.prepareForNextBuild() that 
returns false (can't do incremental) if an outjar is specified. This ensures 
that results are at least always correct. We can do better post 1.2 when we have 
more time to update the test harness.
Comment 2 Adrian Colyer CLA 2004-03-19 09:41:29 EST 
updating target flag to indicate inclusion in 1.2 release.