Bug 545960 - Declutter Helgrind output
Summary: Declutter Helgrind output
Status: CLOSED WONTFIX
Alias: None
Product: Linux Tools
Classification: Tools
Component: Valgrind (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Roland Grunberg CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: ui, usability
Depends on:
Blocks:
 
Reported: 2019-03-30 13:13 EDT by Michael von Glasow CLA
Modified: 2023-03-11 06:31 EST (History)
2 users (show)

See Also:


Attachments
Helgrind Screenshot (90.94 KB, image/png)
2019-03-30 13:13 EDT, Michael von Glasow CLA
no flags Details
Memcheck Screenshot (94.04 KB, image/png)
2019-03-30 13:15 EDT, Michael von Glasow CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael von Glasow CLA 2019-03-30 13:13:42 EDT
Created attachment 278077 [details]
Helgrind Screenshot

While I found Memcheck very easy to work with (despite never having used Valgrind or anything similar before), I cannot say the same about Helgrind. This is mainly because I find the UI confusing.

Memcheck consistently has one top-level line per error/event (e.g use of uninitialized variable, out-of-bound memory access, invalid memory access), which I can then open up to drill down more deeply.

In Helgrind, in contrast, one event (e.g. thread creation, possible race condition) may generate multiple top-level lines.

Some of them carry no useful information (e.g. "Thread Announcement", a dashed line and the PID—which is repeated in every message). If they have no child nodes, my suggestion would be to simply discard them. If they have children (as seen in the second-last line of the screenshot) I would suggest promoting the first child to top level and placing its "siblings" underneath.

On other occasions, it takes a very close look to see which lines go together: in a list view it is not immediately obvious that the dashed lines apparently are separators, and while that kind of UX may be OK for a console app, it doesn’t lend itself well to a tree view GU. My suggestion would be to rearrange lines into a tree structure with a single parent if they refer to the same event. Taking the four-liner near the bottom of the screenshot:

Current:
  * Possible data race during read of size 8 at (address) by thread #2
  * Locks held: none
    * (stack trace etc.)
  * This conflicts with a previous write of size 8 by thread #1
  * Locks held: none
    * (stack trace etc.)

Suggested:
  * Possible data race during read of size 8 at (address) by thread #2
    * Locks held: none
      * (stack trace etc.)
    * This conflicts with a previous write of size 8 by thread #1
      * Locks held: none
        * (stack trace etc.)

This would be consistent with Memcheck and IMHO improve user experience.
Comment 1 Michael von Glasow CLA 2019-03-30 13:15:14 EDT
Created attachment 278078 [details]
Memcheck Screenshot

Memcheck screenshot for comparison: one event corresponds to one top-level entry in the list.
Comment 2 Michael von Glasow CLA 2019-03-30 13:18:57 EDT
PS: cannot select my version here, Eclipse tells me I have 7.2.0.201903121920.
Comment 3 Eclipse Genie CLA 2021-03-20 03:54:09 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Michael von Glasow CLA 2021-03-20 07:06:52 EDT
Just updating to 8.2.0.202103091924, then I will check. However, this is not the kind of bug that would get fixed as a side effect of something else: we’re talking about UI redesign here, and if somebody fixed that, they would know.
Comment 5 Michael von Glasow CLA 2021-03-20 11:57:54 EDT
And yes, 8.2.0.202103091924 still exhibits the same behavior.
Comment 6 Eclipse Genie CLA 2023-03-11 06:31:26 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.