545768 – Generic Editor Diagnostic Cache not updating initially

Bug 545768 - Generic Editor Diagnostic Cache not updating initially

Summary: Generic Editor Diagnostic Cache not updating initially

Status:	CLOSED FIXED

Alias:	None

Product:	ECP
Classification:	Modeling
Component:	EMF Forms (show other bugs)
Version:	1.19.0
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	1.21.0
Assignee:	Eugen Neufeld
QA Contact:

URL:
Whiteboard:
Keywords:	test

Depends on:
Blocks:

Reported:	2019-03-25 17:49 EDT by Eugen Neufeld
Modified:	2019-03-29 12:23 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eugen Neufeld

2019-03-25 17:49:22 EDT

The Diagnostic cache does not update initially.
Moved code from EcoreCache to DiagnosticCache.

Comment 1 Eclipse Genie

2019-03-25 17:50:51 EDT

New Gerrit change created: https://git.eclipse.org/r/139460

Comment 2 Eclipse Genie

2019-03-26 09:28:24 EDT

Gerrit change https://git.eclipse.org/r/139460 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=c1ba3fa67760162e36a61f8e55d3c986a0ac956a

Comment 3 Eclipse Genie

2019-03-26 09:28:25 EDT

New Gerrit change created: https://git.eclipse.org/r/139493

Comment 4 Eclipse Genie

2019-03-26 10:58:17 EDT

Gerrit change https://git.eclipse.org/r/139493 was merged to [specialbuild_20190325].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=282e5e2c56b534a90c1db914ab24214fc3158cb4

Comment 5 Jonas Helming

2019-03-28 11:29:46 EDT

Should this get the testing tag?

Comment 6 Jonas Helming

2019-03-29 04:43:01 EDT

Please provide testing information

Comment 7 Eugen Neufeld

2019-03-29 12:23:33 EDT

The change moves the initialization of markers from the ecore specific cache into the diagnostic cache.

Users of the GenericEditor and the DiagnosticCache should check for possible negative performance effect. Furthermore they should check that all markers are still presented correctly especially when opening the editor.