Community
Participate
Working Groups
1) create eclipse application launch configuration based on selected features (all features are selected by default) 2) enter some filter (e.g. "emf") 3) apply, close and reopen the launch config --> only emf features are selected
The issue is caused because CheckboxTreeViewer#getChecked and #getCheckedElements omit filtered elements. The expectation when using CachedCheckboxTreeViewer is generally that filtering should only affect the UI, not the checked set. Also affected are e.g the import feature and export plugin wizard: both skip selected but filtered elements. Import "Projects from Folder or Archive" for example does not. @Andrey, WDYT is the correct behavior regarding the wizards? I would tend to override both methods in CachedCheckboxTreeViewer so they ignore filters.
(In reply to Julian Honnen from comment #1) > The issue is caused because CheckboxTreeViewer#getChecked and > #getCheckedElements omit filtered elements. The expectation when using > CachedCheckboxTreeViewer is generally that filtering should only affect the > UI, not the checked set. This bug is related to bug 441684, but it is not about wizards. I also see that the "Restore" button with active filter set only restores the state for the filtered elements, same for "Select All/Deselect All/Select Required". I guess it would make sense to clear the filter first before performing actions, so that user immediately sees that they operate on the *all* elements, not just on filtered. > Also affected are e.g the import feature and export plugin wizard: both skip > selected but filtered elements. Import "Projects from Folder or Archive" for > example does not. > > @Andrey, WDYT is the correct behavior regarding the wizards? I would tend to > override both methods in CachedCheckboxTreeViewer so they ignore filters. Can we fix this one and create a separated bug for discussion about wizards behavior?
(In reply to Andrey Loskutov from comment #2) > This bug is related to bug 441684, but it is not about wizards. It is a bit, insofar that those wizards use the same filtered tree viewer - which should behave similarly across PDE. > I also see > that the "Restore" button with active filter set only restores the state for > the filtered elements, same for "Select All/Deselect All/Select Required". I > guess it would make sense to clear the filter first before performing > actions, so that user immediately sees that they operate on the *all* > elements, not just on filtered. That is definitely inconsistent compared to a plugin based launch config. Please comment on bug 545735. > Can we fix this one and create a separated bug for discussion about wizards > behavior? Sure. --> Bug 545736
New Gerrit change created: https://git.eclipse.org/r/139469
Gerrit change https://git.eclipse.org/r/139469 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=5d8de12c6bcecaa8d052491917d2c65b788b84b4
Can bug reporter or bug assignee please verify this defect for 4.12M1?
verified on I20190520-1805
