Bug 545677 - False positive "Missing @since tag" error
Summary: False positive "Missing @since tag" error
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.11   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2019-03-22 11:12 EDT by Alexander Kurtakov CLA
Modified: 2023-04-26 12:20 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov CLA 2019-03-22 11:12:12 EDT
If a child overrides public method from parent api tools complain about missing @since tag like:
Description	Resource	Path	Location	Type
Missing @since tag on dispose()	TableItem.java	/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets	line 243	@since tag problem

Open org.eclipse.swt, copy .classpath_gtk to .classpath, setup apitools and you'll see the warning.
Comment 1 Alexander Kurtakov CLA 2019-03-22 11:13:25 EDT
Adding Dani as he pointed to me that is is pde api tools in https://git.eclipse.org/r/#/c/139323/
Comment 2 Dani Megert CLA 2019-03-22 11:46:23 EDT
This seems to be a special case/scenario. To check I added

org.eclipse.jdt.ui.wizards.NewElementWizardPage.getImage() and no API Tools error was issued. When I add org.eclipse.jdt.ui.wizards.NewElementWizardPage.newOne() I do get a missing @since tag error.
Comment 3 Vikas Chandra CLA 2019-03-27 06:16:17 EDT
I cant reproduce it on windows. I guess this isssue is same as https://bugs.eclipse.org/bugs/show_bug.cgi?id=532282#c0
Comment 4 Alexander Kurtakov CLA 2019-03-30 04:49:17 EDT
(In reply to Vikas Chandra from comment #3)
> I cant reproduce it on windows. I guess this isssue is same as
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=532282#c0

There is no way you can reproduce it on windows as the overriden methods are there on Gtk only. Please try coping .classpath_gtk to be your .classpath and try.
Comment 5 Vikas Chandra CLA 2019-03-31 03:32:20 EDT
>>s as the overriden methods 

I tried to override the same method in windows and I expected this problem to surface.

>> Please try coping .classpath_gtk to be your .classpath and try.

Does this problem happen for you all the time or is the problem intermittent?
Comment 6 Alexander Kurtakov CLA 2019-03-31 03:46:31 EDT
(In reply to Vikas Chandra from comment #5)
> >>s as the overriden methods 
> 
> I tried to override the same method in windows and I expected this problem
> to surface.
> 
> >> Please try coping .classpath_gtk to be your .classpath and try.
> 
> Does this problem happen for you all the time or is the problem intermittent?

Always, at first there is warning that I should bump minor version due to new api added after doing that the described warnings are come. Caused by same root cause IMHO.
Comment 7 Vikas Chandra CLA 2019-03-31 04:01:25 EDT
Looks like a different problem then ( and not this one https://bugs.eclipse.org/bugs/show_bug.cgi?id=532282#c0)

I'll investigate this for 4.12
Comment 8 Vikas Chandra CLA 2019-05-15 05:32:00 EDT
I tried this on linux machine and was unable to recreate.

Alex, can you give detailed steps ?
Comment 9 Eclipse Genie CLA 2021-05-05 15:23:35 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 10 Eclipse Genie CLA 2023-04-26 12:20:17 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.