Community
Participate
Working Groups
Bug 544880 fixed a problem in which the View Editor's model tree cut/copy/paste actions were invoked when attempting to cut/copy/paste in text fields in the detail panel of the master-detail form. This was fixed locally in that editor's action-bar contributor. Any other form-based editor that uses a master-detail tree view will need a similar treatment, so the fix employed in this editor should be factored out into something more generally applied. Preferable would be to implement that behaviour once in each of - TreeMasterDetailComposite (used by GenericEditor) - TreeMasterDetailSWTRenderer (used by ViewEditorPart and others) and not in the action-bar contributors.
Also, the JUnit tests implemented for bug 544880 do not work on Mac (Cocoa) platform.
New Gerrit change created: https://git.eclipse.org/r/138860
Gerrit change https://git.eclipse.org/r/138860 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=4a370dd3a698b8e65da1261bd7e25363d3bcc0c9
(In reply to Eclipse Genie from comment #3) > Gerrit change https://git.eclipse.org/r/138860 was merged to [develop].
Released in the milestone/special build.
Should this get the "testing" tag due to possible regressions?
Please provide testing information
Regression testing of the View Model Editor is covered by the JUnit tests. To test any other form editor that uses a tree master-detail as its main view, you would first have to register the EMF EditingDomainActionBarContributor class as its action-bar contributor. And if it is not a subclass of the GenericEditor, then also register the tree's selection provider as the editor site's selection provider. Then test that - when the input focus is in the tree, cut/copy/paste/delete key bindings operate on nodes of the tree as expected - when the input focus is on a text widget in the detail pane for some object in the the tree, cut/copy/paste/delete key bindings operate on the text in that widget - when the input focus is on a table or other complex widget in the detail pane, if that table provides any cut/copy/paste/delete actions on the standard key bindings, then they work as expected in that context - try switching the focus back and forth between tree and details in the editor and across multiple instances of the editor to verify that the correct actions are invoked by the keyboard bindings (and/or Edit menu actions)
