Bug 545450 - Move common functionality from IGesture implementations to AbstractGesture
Summary: Move common functionality from IGesture implementations to AbstractGesture
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF MVC (show other bugs)
Version: 5.0.100   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Matthias Wienand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-15 11:38 EDT by Matthias Wienand CLA
Modified: 2019-09-12 15:46 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Wienand CLA 2019-03-15 11:38:46 EDT 
Currently, the individual IGesture implementations share some implementation details. In order to de-duplicate the code, we should pull up the common functionality into the AbstractGesture base class.

At least the setup of scene listeners and their initial invocation (as well as final clean-up) can probably be moved to AbstractGesture, i.e. the code currently executed in individual doActivate() and doDeactivate() callbacks.
Comment 1 Matthias Wienand CLA 2019-09-12 15:46:16 EDT 
I refactored most of the gestures, except for ScrollGesture and TypeStrokeGesture, which pass special parameters to some methods (a viewer and a set of pressed keys, respectively). These need to be looked at in more detail to refactor appropriately.