Comment 1 Eclipse Genie 2019-02-26 11:35:17 EST

New Gerrit change created: https://git.eclipse.org/r/137654

Comment 2 Steve Monnier 2019-03-04 08:46:27 EST

Created attachment 277749 [details]
RemoveBendpoints.zip

Validation steps:
- Import project from RemoveBendpoints.zip.
- Open "new userCase" diagram.
- Select edge18 and trigger the contextual action "Remove Bendpoints". Check that the source is now at the center of the east side and the target at the center of the south side.
- Select edge19 and trigger the contextual action "Remove Bendpoints". Check that the source is now at the center of the north side and the target at the center of the east side.
- Select edge20 and trigger the contextual action "Remove Bendpoints". Check that the source is now at the center of the west side and the target at the center of the north side.
- Select edge21 and trigger the contextual action "Remove Bendpoints". Check that the edge has not changed.

Comment 3 Eclipse Genie 2019-03-08 08:14:54 EST

Gerrit change https://git.eclipse.org/r/137654 was merged to [v6.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a10ecf19004d400d81fe0de2c35d79fad0bade1d

Comment 4 Steve Monnier 2019-03-08 10:09:06 EST

Note that the metamodel is available in sirius org.eclipse.sirius.tests.sample.migration

Comment 5 Eclipse Genie 2019-03-21 09:15:39 EDT

New Gerrit change created: https://git.eclipse.org/r/139226

Comment 6 Eclipse Genie 2019-03-21 09:15:42 EDT

New Gerrit change created: https://git.eclipse.org/r/139227

Comment 7 Steve Monnier 2019-03-21 09:52:04 EDT

Reopened to include a fix where on a new edge, after removing bendpoints moving a bendpoint or segment of the edge leads to the following exception

java.lang.IndexOutOfBoundsException: Index: 3, Size: 1
at java.util.ArrayList.rangeCheck(ArrayList.java:653)
at java.util.ArrayList.get(ArrayList.java:429)
at org.eclipse.gmf.runtime.gef.ui.internal.editpolicies.ConnectionBendpointEditPolicy.getLineSeg(ConnectionBendpointEditPolicy.java:599)
at org.eclipse.gmf.runtime.gef.ui.internal.editpolicies.ConnectionBendpointEditPolicy.showMoveLineSegFeedback(ConnectionBendpointEditPolicy.java:788)
at org.eclipse.sirius.diagram.ui.graphical.edit.policies.TreeLayoutConnectionLineSegEditPolicy.showMoveLineSegFeedback(TreeLayoutConnectionLineSegEditPolicy.java:169)
at org.eclipse.sirius.diagram.ui.graphical.edit.policies.TreeLayoutConnectionLineSegEditPolicy.showSourceFeedback(TreeLayoutConnectionLineSegEditPolicy.java:185)
at org.eclipse.gef.editparts.AbstractEditPart.showSourceFeedback(AbstractEditPart.java:1093)
at org.eclipse.gmf.runtime.diagram.ui.editparts.ConnectionEditPart.showSourceFeedback(ConnectionEditPart.java:1664)
at org.eclipse.gmf.runtime.gef.ui.internal.tools.SelectConnectionEditPartTracker.showSourceFeedback(SelectConnectionEditPartTracker.java:216)
at org.eclipse.gmf.runtime.gef.ui.internal.tools.SelectConnectionEditPartTracker.handleDragInProgress(SelectConnectionEditPartTracker.java:144)
at org.eclipse.sirius.diagram.ui.tools.internal.ui.SiriusSelectConnectionEditPartTracker.handleDragInProgress(SiriusSelectConnectionEditPartTracker.java:172)
at org.eclipse.gef.tools.AbstractTool.mouseDrag(AbstractTool.java:1114)
at org.eclipse.sirius.diagram.ui.tools.internal.ui.SiriusSelectConnectionEditPartTracker.mouseDrag(SiriusSelectConnectionEditPartTracker.java:149)
at org.eclipse.gef.tools.SelectionTool.mouseDrag(SelectionTool.java:538)

Comment 8 Eclipse Genie 2019-03-21 10:00:03 EDT

Gerrit change https://git.eclipse.org/r/139226 was merged to [v6.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5b0e67857b1ada4c56a954d13318753ad250ac19

Comment 9 Steve Monnier 2019-03-21 11:23:28 EDT

The fix has been merged but not the auto test as SWTBot does not allow us to move a bendpoint of a reclinear edge for some reason.

Extended Validation Steps:
- Import project from RemoveBendpoints.zip.
- Open "new userCase" diagram.
- Select edge18 and trigger the contextual action "Remove Bendpoints". Check that the source is now at the center of the east side and the target at the center of the south side.
- Select edge19 and trigger the contextual action "Remove Bendpoints". Check that the source is now at the center of the north side and the target at the center of the east side.
- Select edge20 and trigger the contextual action "Remove Bendpoints". Check that the source is now at the center of the west side and the target at the center of the north side.
- Select edge21 and trigger the contextual action "Remove Bendpoints". Check that the edge has not changed.
- Create a edge with the same source and target. Use the tabbar action "Line Style" and set it to "Rectilinear Style Routing". Trigger the contextual action "Remove Bendpoints". Check that you can move bendpoints and segments without having exceptions while you move.

Comment 10 Eclipse Genie 2019-03-21 11:46:08 EDT

New Gerrit change created: https://git.eclipse.org/r/139246

Comment 11 Eclipse Genie 2019-03-28 10:55:17 EDT

New Gerrit change created: https://git.eclipse.org/r/139686

Comment 12 Eclipse Genie 2019-04-01 10:56:45 EDT

Gerrit change https://git.eclipse.org/r/139686 was merged to [v6.1.x].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=44643477e2cc7199fabff7ecd5acdcc1907ae475

Comment 13 Jerome Pequery 2019-05-28 05:17:05 EDT

Validated with T4C 1.3.1 it5

Comment 14 Pierre-Charles David 2019-06-17 10:46:53 EDT

Available in Sirius 6.1.3, see https://wiki.eclipse.org/Sirius/6.1.3