Bug 544358 - NPE in server discovery from serverAdapterSitesDetails.xml contents
Summary: NPE in server discovery from serverAdapterSitesDetails.xml contents
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.13   Edit
Hardware: PC Mac OS X
: P3 major (vote)
Target Milestone: 3.13   Edit
Assignee: Elson Yuen CLA
QA Contact: Elson Yuen CLA
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-02-11 23:06 EST by Nitin Dahyabhai CLA
Modified: 2019-02-14 17:17 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nitin Dahyabhai CLA 2019-02-11 23:06:03 EST 
The following NPE happens when reading the shipping org.eclipse.wst.server.discovery/serverAdapterSitesDetails.xml contents after pressing the Add button in the Server Runtime Environments preference page.

In org.eclipse.wst.server.discovery.internal.XMLMemento#createReadRoot(InputStream), the first child node of the file is a copyright comment, causing a null to be returned.

!ENTRY org.eclipse.wst.server.discovery 4 0 2019-02-11 23:01:53.587
!MESSAGE Could not get extension items details
!STACK 1
org.eclipse.core.runtime.CoreException: 
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExtensionUpdateSitesDetails(ExtensionUtility.java:164)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExtensionUpdateSitesDetails(ExtensionUtility.java:288)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getAllExtensionsWithServer(ExtensionUtility.java:466)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExtensionsWithServer(ExtensionUtility.java:550)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.refreshServerAdapters(ExtensionUtility.java:681)
	at org.eclipse.wst.server.discovery.Discovery.refreshServerAdapters(Discovery.java:68)
	at org.eclipse.wst.server.ui.ServerUIUtil$1RefreshJob.run(ServerUIUtil.java:109)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Caused by: java.lang.NullPointerException
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExtensionUpdateSitesDetails(ExtensionUtility.java:77)
	... 7 more
!SUBENTRY 1 org.eclipse.wst.server.discovery 4 0 2019-02-11 23:01:53.592
!MESSAGE 
!STACK 0
java.lang.NullPointerException
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExtensionUpdateSitesDetails(ExtensionUtility.java:77)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExtensionUpdateSitesDetails(ExtensionUtility.java:288)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getAllExtensionsWithServer(ExtensionUtility.java:466)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.getExtensionsWithServer(ExtensionUtility.java:550)
	at org.eclipse.wst.server.discovery.internal.ExtensionUtility.refreshServerAdapters(ExtensionUtility.java:681)
	at org.eclipse.wst.server.discovery.Discovery.refreshServerAdapters(Discovery.java:68)
	at org.eclipse.wst.server.ui.ServerUIUtil$1RefreshJob.run(ServerUIUtil.java:109)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
Comment 1 Eclipse Genie CLA 2019-02-14 16:42:49 EST 
New Gerrit change created: https://git.eclipse.org/r/136960
Comment 3 Elson Yuen CLA 2019-02-14 17:17:41 EST 
Code release to master