Bug 544257 - [12][quick fix] Enable preview features should open preferences only when defaults are not used
Summary: [12][quick fix] Enable preview features should open preferences only when def...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.11   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: BETA J12   Edit
Assignee: Kalyan Prasad Tatavarthi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 543668
Blocks: 536055 545120
  Show dependency tree
 
Reported: 2019-02-08 00:41 EST by Noopur Gupta CLA
Modified: 2019-04-11 02:27 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2019-02-08 00:41:37 EST 
From bug 543668 comment #6:

In 99% of the cases we can just change the settings. No need to open the project settings. Only if the project settings aren't using the defaults, we can show them. And in that case the quick fix should have another label, e.g. "Open compiler settings".
Comment 1 Noopur Gupta CLA 2019-02-08 00:51:18 EST 
Kalyan, can you please investigate this if you are not working on any other Java 12 bug?
Comment 2 Dani Megert CLA 2019-02-09 11:13:43 EST 
Even if other options aren't default we might be able to enable the preview features. Needs to be looked at more closely.
Comment 3 Eclipse Genie CLA 2019-02-12 05:55:06 EST 
New Gerrit change created: https://git.eclipse.org/r/136755
Comment 4 Kalyan Prasad Tatavarthi CLA 2019-03-06 05:24:53 EST 
Gerrit change https://git.eclipse.org/r/136755 was merged to [BETA_JAVA_12].
Commit: https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?h=BETA_JAVA_12&id=5f38ded6c00993ba75f3834c25de97962dfef1cc
Comment 5 Eclipse Genie CLA 2019-03-06 13:53:50 EST 
Gerrit change https://git.eclipse.org/r/136755 was merged to [BETA_JAVA_12].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=5f38ded6c00993ba75f3834c25de97962dfef1cc
Comment 6 Noopur Gupta CLA 2019-04-04 05:57:50 EDT 
Kalyan, please add N&N entry for 4.12 M1 as it is not included in https://wiki.eclipse.org/Java12/Examples also.
Comment 7 Eclipse Genie CLA 2019-04-10 05:53:51 EDT 
New Gerrit change created: https://git.eclipse.org/r/140347
Comment 9 Kalyan Prasad Tatavarthi CLA 2019-04-11 02:27:00 EDT 
Verified in the build I20190410-1800