Bug 544093 - "Related Topics" view doesn't honor priority of remote help preferences
Summary: "Related Topics" view doesn't honor priority of remote help preferences
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Doc (show other bugs)
Version: 4.11   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-Doc-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-04 07:51 EST by mavami mavami CLA
Modified: 2023-01-16 03:15 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mavami mavami CLA 2019-02-04 07:51:56 EST
Remote help is enabled: Window -> Preferences -> Content -> Include remote help and give it priority

But "Related Topics" view seems to ignore it and shows content from local help. Only in case if local help is missing it shows content from remote help.

org.eclipse.help.internal.context.ContextManager#getContextProviders() always returns list of available providers starting with local ones.

Due to this in ContextManager#getContext() it returns first available context which is not null without checking for IHelpBaseConstants.P_KEY_REMOTE_HELP_PREFERRED:

Iterator iter = getContextProviders(pluginId).iterator();
while (iter.hasNext()) {
AbstractContextProvider provider = (AbstractContextProvider)iter.next();
try {
  IContext context = provider.getContext(contextId, locale);
  if (context != null) {
    if (HelpPlugin.DEBUG_CONTEXT) {						 
      System.out.println("ContextManager.getContext found context, description = \"" + context.getText() + '"'); //$NON-NLS-1$					}
return new Context(context, contextId);
}
}
Comment 1 Eclipse Genie CLA 2021-01-25 04:33:57 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Eclipse Genie CLA 2023-01-16 03:15:25 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.