Description Andrey Loskutov 2019-01-17 03:30:21 EST

While patching PDE for bug 543490 I've noticed that organize imports automatically replaced almost all imports with *, and curly braces were automatically added for all if/else statements.

This made the original diff for https://git.eclipse.org/r/135175 3x bigger as the actual, adding a lot of noise, so I had to manually revert all the automated changes to have a clean patch.

The first problem is because we have org.eclipse.jdt.ui.ondemandthreshold=3 set in PDE settings, but this seem never be consistently used.

I've searched my workspace and I see that from 99 projects I have opened in platform, 26 use "3" and 73 projects use "99" as limit.

From 28 PDE projects 11 use "3", 3 projects use "5" and the rest uses workspace default (99).

Also looks like the code was never managed according to the settings, so even if the project says "3", some imports were added with "99" and so this leads to unexpected "automated" edits on save.

Same is for "convert control statement bodies to block" - it is set in PDE core but not in the UI, and the code uses a funny mix of both styles.

So I think we should harmonize this and use 99 / "convert control statement bodies to block" everywhere. This is also workspace default setting.

I propose to do this in two shots: organize imports / add braces around if/else.

I plan to provide patches.