Comment 1 Lucas Koehler 2018-12-12 12:17:14 EST

Created attachment 276916 [details]
Table column with inverted sorting

The attached image shows the inverted sorting

Comment 2 Eclipse Genie 2018-12-12 12:19:26 EST

New Gerrit change created: https://git.eclipse.org/r/133947

Comment 3 Eclipse Genie 2018-12-20 09:35:02 EST

Gerrit change https://git.eclipse.org/r/133947 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=f3dbb512842dfca562bc9be7430322484c8ee89b

Comment 4 Jonas Helming 2019-01-16 03:38:49 EST

should we add the "test" tag here?

Comment 5 Lucas Koehler 2019-01-30 08:41:23 EST

I do not think it is necessary. As a user I click and immediately see if it is sorted how I expect it. If not I click once more. Also the fact that nobody even noticed this for years indicates that users just click the column header until it is sorted how they expect.

Comment 6 Jonas Helming 2019-01-30 08:43:52 EST

I am not sure if arrows pointing upwards or downwards are always interpreted the same by all users. As this BR changes the visible behavior in the UI, I think it is by definition "test"

Comment 7 Lucas Koehler 2019-01-30 09:38:27 EST

TEST INFORMATION
Summary of the critical part of the change
The direction of the arrows indicating the sort direction in a table column were fixed. Now the arrow is pointing downwards if the column is sorted descendingly and the other way around.

Potential regressions
The arrow directions are inverted now. This could irritate a user.

Affected areas / use cases
Sorting of table columns

Things that shall be tested
That the sorting still works as expected and users are not confused when sorting columns