Bug 542425 - [Target editor] New location entries should place the repository before the units
Summary: [Target editor] New location entries should place the repository before the u...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.10   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.12 M3   Edit
Assignee: Alexander Fedorov CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2018-12-05 05:19 EST by Lars Vogel CLA
Modified: 2019-05-21 03:52 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2018-12-05 05:19:11 EST 
If I add a new entry to the target editor, the repository node is placed at the end. Example:

<?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="fx">
	<locations>
		<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
			<unit id="org.eclipse.fx.code.target.feature.feature.group" version="3.4.1.201810030600"/>
			<unit id="org.eclipse.fx.nl.feature.feature.group" version="3.4.1.201810030600"/>
			<unit id="org.eclipse.fx.runtime.min.feature.feature.group" version="3.4.1.201810030500"/>
			<unit id="org.eclipse.fx.slf4j.target.feature.feature.group" version="3.4.1.201810020600"/>
			<unit id="org.eclipse.fx.target.feature.feature.group" version="3.4.1.201810030600"/>
			<unit id="org.eclipse.fx.target.rcp.feature.feature.group" version="3.4.1.201810030600"/>
			<unit id="org.eclipse.fx.target.rcp4.feature.feature.group" version="3.4.1.201810030600"/>
			<repository location="http://download.eclipse.org/efxclipse/runtime-released/3.4.1/site"/>
		</location>
	</locations>
</target>

If I later Edit the entry, the repository is moved to the first position.

<?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="fx">
	<locations>
		<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="slicer" includeSource="true" type="InstallableUnit">
			<repository location="http://download.eclipse.org/efxclipse/runtime-nightly/site/"/>
			<unit id="org.eclipse.fx.slf4j.target.feature.feature.group" version="3.5.0.201812040700"/>
		</location>
	</locations>
</target>

First position is IMHO better, we should always use it.
Comment 1 Lars Vogel CLA 2019-01-08 10:42:42 EST 
Alexander/Julian, WDYT?
Comment 2 Eclipse Genie CLA 2019-04-24 02:22:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/141032
Comment 4 Julian Honnen CLA 2019-04-24 04:08:32 EDT 
Thanks Alexander.
Comment 5 Vikas Chandra CLA 2019-05-21 02:55:08 EDT 
Can the bug submitter/bug assignee please verify this defect for 4.12 M3?
Comment 6 Alexander Fedorov CLA 2019-05-21 03:52:40 EDT 
Eclipse SDK
Version: 2019-06 (4.12)
Build id: I20190520-1805
OS: Windows 10, v.10.0, x86_64 / win32
Java version: 1.8.0_211