Bug 542105 - [test] Rethink JRE filter in ModuleBuilderTests
Summary: [test] Rethink JRE filter in ModuleBuilderTests
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.10   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.11 M1   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2018-12-04 15:14 EST by Stephan Herrmann CLA
Modified: 2019-01-08 05:23 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2018-12-04 15:14:48 EST 
Follow-up from bug 541015 comment 9:

ModuleBuilderTests.testBug541015 accidentally runs even on JRE 8-

I would hope there's a simple way to disable the entire suite if !isJRE9.
If that's not possible then the mentioned test needs this check added.
Comment 1 Eclipse Genie CLA 2019-01-06 12:01:36 EST 
New Gerrit change created: https://git.eclipse.org/r/134694
Comment 3 Stephan Herrmann CLA 2019-01-06 13:36:49 EST 
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/134694 was merged to [master].
> Commit:
> http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/
> ?id=ca62329fead9ba47ab1cc79d4fce6a2cbd6439dd

Fix released for 4.11 M1: if (!isJRE9) we simply create an almost empty suite (containing only one test to remind us that tests only run on 9+).
Comment 4 Manoj N Palat CLA 2019-01-08 05:23:54 EST 
Verified for Eclipse 4.11 M1 with Build id: I20190107-0600