Bug 541756 - Modular IO in forte needs a cleanup
Summary: Modular IO in forte needs a cleanup
Status: NEW
Alias: None
Product: 4DIAC
Classification: IoT
Component: FORTE (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 10
: P3 normal
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-30 10:40 EST by Jose Maria Jesus Cabral Lassalle CLA
Modified: 2018-12-02 05:47 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Maria Jesus Cabral Lassalle CLA 2018-11-30 10:40:49 EST 
There are some things that are needed in the core/io and embrick and wago. The following list serves as metric to know when to close this bug:

- Replace pointer for references when needed
- Add curly braces to all while, for and if statements
- Add "virtual" to all functions that are overriding parent functions
- Remove duplicated documentation comments in child which are already in parent functions
- Remove unused events in FBs, both in forte and in the IDE
Comment 1 Jose Maria Jesus Cabral Lassalle CLA 2018-12-02 05:47:41 EST 
From comments in some commits, I add here two more points to cleanup:

- Try to remove static variables where possible
- The updateInterval should be of typ TIME instead of UINT